Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix students context menu #6470

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Fix students context menu #6470

merged 3 commits into from
Feb 6, 2023

Conversation

mikeyarce
Copy link
Member

@mikeyarce mikeyarce commented Feb 2, 2023

Fixes #6123

Changes proposed in this Pull Request

  • Previously, I tried to update wp-components to a newer version, but that caused a lot of other problems.
  • Now I'm just using Good Ol' CSS to make it appear.
  • I tested in WP 5.9.5, 6.0.3, 6.1, and 6.1.1 and it looked good in each.

Testing instructions

  • Go to Sensei -> Students
  • Click the ... menu
  • Make sure it opens up

Example:
student-context-menu

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #6470 (0a2b87d) into trunk (8d08dfb) will not change coverage.
The diff coverage is 29.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #6470   +/-   ##
=========================================
  Coverage     46.82%   46.82%           
  Complexity     9741     9741           
=========================================
  Files           464      464           
  Lines         34390    34390           
  Branches        276      276           
=========================================
  Hits          16104    16104           
  Misses        18080    18080           
  Partials        206      206           
Impacted Files Coverage Δ
assets/admin/editor-wizard/patterns-list.js 26.66% <0.00%> (ø)
assets/admin/editor-wizard/steps/patterns-step.js 21.73% <0.00%> (ø)
.../blocks/course-outline/module-block/module-edit.js 68.96% <ø> (ø)
...ludes/blocks/course-theme/class-course-content.php 9.09% <0.00%> (ø)
includes/class-sensei-lesson.php 36.99% <0.00%> (ø)
...ncludes/blocks/class-sensei-block-view-results.php 92.85% <100.00%> (ø)
...udes/blocks/class-sensei-continue-course-block.php 93.02% <100.00%> (ø)
...udes/blocks/class-sensei-course-progress-block.php 91.66% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb9f24...0a2b87d. Read the comment docs.

@mikeyarce mikeyarce requested a review from a team February 2, 2023 23:38
@mikeyarce
Copy link
Member Author

mikeyarce commented Feb 3, 2023

@Imran92 - thanks for your suggestion, I've fixed it in d97fe51

One issue I found is that on mobile the menu is not visible:
Screenshot 2023-02-03 at 10 49 05 AM

I've tried looking at z-index and the stacking order but can't seem to figure out yet why it's always hidden behind. Any ideas on what to do here? Thanks!

Edit: @renatho helped me with this one and I've pushed a fix for mobile screens as well :)

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mikeyarce mikeyarce merged commit 941158c into trunk Feb 6, 2023
@mikeyarce mikeyarce deleted the fix/student-action-menu branch February 6, 2023 17:17
@donnapep donnapep added this to the 4.11.2 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 dots menu on Students page opens to the right, half of it not visible
3 participants