Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensei logo to the default learning mode template #6913

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented May 25, 2023

Resolves #6742

Proposed Changes

  • Create a sensei logo block with a link to sensei
  • Add the block to the default learning mode template.
  • Update the Sensei->assets->get_icon to receive width and height

Testing Instructions

Figma: 8mY8ui4zYK1Ylw2yIFi9Lx-fi-20020517_40169

  1. Go to this branch
  2. Reset all stored changes on the learning mode template (default)
  3. Check if the sensei logo is visible on the sidebar
  4. Click on the link and check if it is correct.

Supported Themes

It should work on

  • Course Theme
  • Divi Theme
  • Astra Theme.

Screenshots

Editor

image

Frontend

image

Both the PR author and reviewer are responsible for ensuring the checklist is completed. -->

  • PR title and description contain sufficient detail and accurately describe the changes
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari

@gabrielcaires gabrielcaires requested a review from a team May 25, 2023 20:12
@gabrielcaires gabrielcaires self-assigned this May 25, 2023
@gabrielcaires gabrielcaires added this to the 4.15.0 milestone May 25, 2023
@gabrielcaires gabrielcaires changed the title Add sensei logo to the default learning mode tempalte Add sensei logo to the default learning mode template May 25, 2023
@github-actions
Copy link

github-actions bot commented May 25, 2023

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit 9303cc3 and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
course-theme/blocks/index.js 17.2 kB +3.45 kB ( +25.08% 🔼 )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #6913 (a3331ea) into trunk (fdbb06b) will decrease coverage by 1.34%.
Report is 3 commits behind head on trunk.
The diff coverage is 25.00%.

❗ Current head a3331ea differs from pull request most recent head 9303cc3. Consider uploading reports for the commit 9303cc3 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk    #6913      +/-   ##
============================================
- Coverage     48.07%   46.74%   -1.34%     
+ Complexity    10467    10232     -235     
============================================
  Files           573      571       -2     
  Lines         44164    36914    -7250     
  Branches        402      402              
============================================
- Hits          21234    17254    -3980     
+ Misses        22603    19333    -3270     
  Partials        327      327              
Files Changed Coverage Δ
.../blocks/course-theme/class-course-theme-blocks.php 0.00% <0.00%> (ø)
includes/blocks/course-theme/class-sensei-logo.php 0.00% <0.00%> (ø)
includes/class-sensei-assets.php 40.22% <100.00%> (+28.83%) ⬆️

... and 376 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a2b34...9303cc3. Read the comment docs.

@donnapep donnapep removed this from the 4.15.0 milestone May 30, 2023
Base automatically changed from feature/learning-mode-improvements to trunk June 1, 2023 16:01
@gabrielcaires gabrielcaires added this to the 4.16.0 milestone Jun 9, 2023
@donnapep donnapep removed this from the 4.16.0 milestone Jun 21, 2023
@donnapep donnapep removed the request for review from a team January 16, 2024 18:01
@donnapep
Copy link
Collaborator

This one needs some more work, as I wasn't able to get the logo to show on the frontend:

Screenshot 2024-01-16 at 1 15 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensei Logo in Standard Layout: replace the Contact Teacher block in the sidebar with Sensei logo and link
3 participants