-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add progress validation command #7160
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #7160 +/- ##
============================================
+ Coverage 50.31% 50.53% +0.22%
- Complexity 10862 10932 +70
============================================
Files 601 607 +6
Lines 45675 46149 +474
Branches 402 402
============================================
+ Hits 22980 23322 +342
- Misses 22368 22500 +132
Partials 327 327
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
When multiple users have quiz progress on the same quiz, only the last one is migrated.
includes/internal/migration/migrations/class-student-progress-migration.php
Show resolved
Hide resolved
includes/internal/migration/validations/class-progress-validation.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Works as expected :)
I left a few optional suggestions.
This reverts commit f362a09.
Resolves #7079
Proposed Changes
Testing Instructions
add_filter( 'sensei_feature_flag_tables_based_progress', '__return_true' );
.wp sensei validate progress
.Success: Progress data is valid.
.wp_sensei_lms_progress
table.Course/Lesson/Quiz tables based progress not found
error.wp_sensei_lms_progress
table.Data mismatch between comments and tables based progress.
error.Pre-Merge Checklist