-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the quiz answer model #7178
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #7178 +/- ##
=========================================
Coverage 49.80% 49.80%
- Complexity 10650 10656 +6
=========================================
Files 586 589 +3
Lines 45047 45067 +20
Branches 402 402
=========================================
+ Hits 22434 22445 +11
- Misses 22286 22295 +9
Partials 327 327
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* @since $$next_version$$ | ||
*/ | ||
class Comments_Based_Answer extends Answer_Abstract { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we don't have an id for this version, what do you think about throwing an exception here?
Also we don't need it in the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @m1r0! Feels better :)
Part of #7159
Proposed Changes
Testing Instructions
Pre-Merge Checklist