-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use student progress models on the frontend #7185
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #7185 +/- ##
============================================
+ Coverage 50.06% 50.31% +0.24%
- Complexity 10720 10860 +140
============================================
Files 601 601
Lines 45231 45673 +442
Branches 402 402
============================================
+ Hits 22647 22980 +333
- Misses 22257 22366 +109
Partials 327 327
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
657271d
to
7da2cab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While testing I wasn't able to find any bugs, which is amazing for such a big change! 💯 I did find just a few small things.
For the record, it's totally possible that I've missed something... 😅
...tudent-progress/quiz-progress/repositories/class-comments-based-quiz-progress-repository.php
Outdated
Show resolved
Hide resolved
...tudent-progress/quiz-progress/repositories/class-comments-based-quiz-progress-repository.php
Outdated
Show resolved
Hide resolved
...ress/quiz-progress/repositories/class-comment-reading-aggregate-quiz-progress-repository.php
Outdated
Show resolved
Hide resolved
.../student-progress/quiz-progress/repositories/class-tables-based-quiz-progress-repository.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Miroslav Mitev <[email protected]>
…ts-based progress status Co-authored-by: Miroslav Mitev <[email protected]>
Co-authored-by: Miroslav Mitev <[email protected]>
Co-authored-by: Miroslav Mitev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've tested the base flow and didn't find any issues.
Resolves part of #7150
Proposed Changes
find
method for progress repositories to get multiple progress entries.Testing Instructions
New/Updated Hooks
Deprecated Code
Pre-Merge Checklist