Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum required PHP version to 7.4 #7195

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Bump minimum required PHP version to 7.4 #7195

merged 4 commits into from
Sep 29, 2023

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Sep 28, 2023

Proposed Changes

  • Bump minimum required PHP version to 7.4
  • Bump minimum supported WP version for phpcs.

Testing Instructions

  1. The CI should be passing.
  2. Make sure all PHP 7.3 codebase mentions are replaced.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@m1r0 m1r0 self-assigned this Sep 28, 2023
@m1r0 m1r0 added this to the 4.17.1 milestone Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #7195 (349453d) into trunk (f8a80d0) will not change coverage.
Report is 29 commits behind head on trunk.
The diff coverage is 91.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7195   +/-   ##
=========================================
  Coverage     49.83%   49.83%           
  Complexity    10684    10684           
=========================================
  Files           601      601           
  Lines         45160    45160           
  Branches        402      402           
=========================================
  Hits          22504    22504           
  Misses        22329    22329           
  Partials        327      327           
Files Coverage Δ
includes/class-sensei-dependency-checker.php 0.00% <ø> (ø)
includes/class-sensei-utils.php 52.12% <100.00%> (ø)
...ails/generators/class-student-completes-lesson.php 100.00% <100.00%> (ø)
...on/migrations/class-student-progress-migration.php 82.97% <100.00%> (ø)
...t-reading-aggregate-course-progress-repository.php 100.00% <100.00%> (ø)
...e-reading-aggregate-course-progress-repository.php 94.87% <100.00%> (ø)
.../class-tables-based-course-progress-repository.php 100.00% <100.00%> (ø)
...t-reading-aggregate-lesson-progress-repository.php 100.00% <100.00%> (ø)
...e-reading-aggregate-lesson-progress-repository.php 96.00% <100.00%> (ø)
.../class-tables-based-lesson-progress-repository.php 99.35% <100.00%> (ø)
... and 19 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e973cb...349453d. Read the comment docs.

@m1r0 m1r0 requested a review from a team September 28, 2023 22:20
@Imran92
Copy link
Contributor

Imran92 commented Sep 29, 2023

Maybe we need to update these requirements first to be able to merge this one
image

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪨

@m1r0 m1r0 merged commit 2e9b39b into trunk Sep 29, 2023
23 checks passed
@m1r0 m1r0 deleted the update/php-version branch September 29, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants