Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix padding in site editor that prevents full-width alignment from working #7233

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Oct 18, 2023

Resolves #7227.

Proposed Changes

Removes the padding from wp-site-blocks and adds it to sensei-course-theme__main-content instead.

We need to be careful going forward not to add CSS that could affect other block templates, which means we need to target selectors that are only available in Sensei's own block templates.

Testing Instructions

  1. Download the Annalee theme from pNEWy-hkA-p2 and activate it.
  2. In the site editor, edit the "Front Page" template.
  3. Scroll down to the "Ready to transform your life?" group.
  4. Confirm that the group block's alignment is set to "Full width" and that the block extends to the left and right edges of the editor.
  5. As a student, view a Learning Mode lesson in mobile view.
  6. Ensure that the content does not touch the edges of the browser.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.19.0 milestone Oct 18, 2023
@donnapep donnapep self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #7233 (c28c918) into trunk (79c3a7e) will not change coverage.
Report is 1 commits behind head on trunk.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7233   +/-   ##
=========================================
  Coverage     50.24%   50.24%           
  Complexity    10862    10862           
=========================================
  Files           601      601           
  Lines         45753    45753           
  Branches        402      402           
=========================================
  Hits          22989    22989           
  Misses        22437    22437           
  Partials        327      327           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eeced5...c28c918. Read the comment docs.

@donnapep donnapep requested a review from a team October 18, 2023 19:50
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely 👍 Thanks for working on the Annalee theme issues

@donnapep donnapep merged commit c310944 into trunk Oct 19, 2023
24 checks passed
@donnapep donnapep deleted the fix/full-width-blocks-editor branch October 19, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full width blocks are not full width in the editor
2 participants