Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no side spacing applied in quiz in learning mode for mobile view #7247

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Oct 31, 2023

Resolves issue of no side spacing applied in quiz in learning mode for mobile view.

Proposed Changes

  • The lateral spacing for quiz was removed on mobile due to some recent changes. We've fixed that here.
  • Lesson spacing was also not applied except for the default template. We've fixed that both on this PR and the linked Pro PR

Testing Instructions

  1. Checkout this branch of Pro https://github.com/Automattic/sensei-pro/pull/2462
  2. Check every LM template for both lesson and quiz in mobile and desktop
  3. Make sure the spacing on both side is there in all cases

Before:
Screenshot 2023-10-31 at 3 56 20 PM

Screenshot 2023-10-31 at 4 42 29 PM

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@Imran92 Imran92 requested a review from a team October 31, 2023 11:02
@Imran92 Imran92 self-assigned this Oct 31, 2023
@Imran92 Imran92 added this to the 4.19.0 milestone Oct 31, 2023
@Imran92 Imran92 closed this Oct 31, 2023
@Imran92 Imran92 reopened this Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7247 (2b97993) into trunk (c1c3f54) will not change coverage.
Report is 1 commits behind head on trunk.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7247   +/-   ##
=========================================
  Coverage     50.43%   50.43%           
  Complexity    10909    10909           
=========================================
  Files           605      605           
  Lines         45986    45986           
  Branches        402      402           
=========================================
  Hits          23194    23194           
  Misses        22465    22465           
  Partials        327      327           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409ed2e...2b97993. Read the comment docs.

donnapep
donnapep previously approved these changes Oct 31, 2023
Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question about perhaps not needing the change log entry.

Also an FYI that I don't believe we're currently handling padding correctly. We should be leveraging root padding aware alignments, but I'm not sure that we are. This is another thing that would be nice to look at when we have some time to dig deeper into LM.

Regardless, this fixes the issue so I'm approving.

This reverts commit 7468dc1.
@Imran92
Copy link
Contributor Author

Imran92 commented Oct 31, 2023

Left a question about perhaps not needing the change log entry.

Thanks! Removed the changelog entry as the issue was introduced after the last release.

Also an FYI that I don't believe we're currently handling padding correctly. We should be leveraging root padding aware alignments, but I'm not sure that we are. This is another thing that would be nice to look at when we have some time to dig deeper into LM.

Agreed. We can look into it to see how we can apply it in our LM context.

Regardless, this fixes the issue so I'm approving.

Thanks! The review got dismissed after I removed the changelog. Can you kindly approve again?

@Imran92 Imran92 merged commit 208915b into trunk Oct 31, 2023
23 checks passed
@Imran92 Imran92 deleted the fix/no-side-spacing-mobile-lm-quiz branch October 31, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants