-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no side spacing applied in quiz in learning mode for mobile view #7247
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #7247 +/- ##
=========================================
Coverage 50.43% 50.43%
Complexity 10909 10909
=========================================
Files 605 605
Lines 45986 45986
Branches 402 402
=========================================
Hits 23194 23194
Misses 22465 22465
Partials 327 327 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question about perhaps not needing the change log entry.
Also an FYI that I don't believe we're currently handling padding correctly. We should be leveraging root padding aware alignments, but I'm not sure that we are. This is another thing that would be nice to look at when we have some time to dig deeper into LM.
Regardless, this fixes the issue so I'm approving.
This reverts commit 7468dc1.
Thanks! Removed the changelog entry as the issue was introduced after the last release.
Agreed. We can look into it to see how we can apply it in our LM context.
Thanks! The review got dismissed after I removed the changelog. Can you kindly approve again? |
Resolves issue of no side spacing applied in quiz in learning mode for mobile view.
Proposed Changes
Testing Instructions
Before:
Pre-Merge Checklist