Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text that "Don't allow self-enrollment" setting is not available for paid courses #7250

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

renatho
Copy link
Contributor

@renatho renatho commented Oct 31, 2023

Proposed Changes

Testing Instructions

  1. Navigate to the course editor.
  2. Open the settings.
  3. Make sure the text is updated.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@renatho renatho self-assigned this Oct 31, 2023
@renatho renatho changed the title Add text that setting is not available for paid courses Add text that "Don't allow self-enrollment" setting is not available for paid courses Oct 31, 2023
@renatho renatho requested a review from a team October 31, 2023 22:43
@renatho renatho added this to the 4.19.0 milestone Oct 31, 2023
@renatho renatho marked this pull request as ready for review October 31, 2023 22:43
Copy link

WordPress Dependencies Report

The github-action-wordpress-dependencies-report action has detected some script changes between the commit 348fb2b and trunk. Please review and confirm the following are correct before merging.

Script Handle Added Dependencies Removed Dependencies Total Size Size Diff
js/admin/course-edit.js 10.2 kB +1 B ( +0.01% 🔼 )

This comment was automatically generated by the github-action-wordpress-dependencies-report action.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #7250 (348fb2b) into trunk (b58d51a) will not change coverage.
Report is 1 commits behind head on trunk.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7250   +/-   ##
=========================================
  Coverage     50.46%   50.46%           
  Complexity    10923    10923           
=========================================
  Files           605      605           
  Lines         46027    46027           
  Branches        402      402           
=========================================
  Hits          23228    23228           
  Misses        22472    22472           
  Partials        327      327           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e35a9...348fb2b. Read the comment docs.

Copy link
Member

@merkushin merkushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as expected :)

@donnapep donnapep merged commit 1a2844e into trunk Nov 1, 2023
23 of 25 checks passed
@donnapep donnapep deleted the change/dont-allow-self-enrollment-help-text branch November 1, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants