-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiz submission validation CLI command #7251
Conversation
WordPress Dependencies ReportThe No changes detected in the current commit. But the comment was left so it is possible to check for the edit history. This comment was automatically generated by the |
Codecov Report
@@ Coverage Diff @@
## trunk #7251 +/- ##
============================================
+ Coverage 50.53% 50.74% +0.20%
- Complexity 10932 11020 +88
============================================
Files 607 610 +3
Lines 46149 46544 +395
Branches 402 402
============================================
+ Hits 23322 23619 +297
- Misses 22500 22598 +98
Partials 327 327
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3572a51
to
c148365
Compare
c148365
to
70e315d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great! 💯
I've noticed some small code duplication between the validation classes but there is not much logic in that code so I think it's ok. 👍
Resolves #7077
Proposed Changes
Testing Instructions
sensei-version
fromwp_options
if you don't.)wp sensei validate quiz-submission
before running migration. It is expected to get a bunch of errors likeTables-based submission not found
.If it is not the first run, delete two options:
wp sensei validate quiz-submission
after migration. No errors expected.Pre-Merge Checklist