Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix question description not being displayed #7669

Merged
merged 9 commits into from
Aug 20, 2024
Merged

Fix question description not being displayed #7669

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
14a08b7
Revert change to quizzes
donnapep Aug 16, 2024
3c350d1
Revert changes for Course Actions block
donnapep Aug 16, 2024
6fbe3e2
Add change log entry
donnapep Aug 16, 2024
22358e4
Merge branch 'trunk' into revert/quiz-question-rendering
donnapep Aug 16, 2024
4482a5c
No `render_callback` for quiz description and question answer blocks
donnapep Aug 19, 2024
bd0e45a
Keep `render_quiz_question` deprecated as it's not used
donnapep Aug 19, 2024
d1399a9
Put PHPCS rule on proper line
donnapep Aug 19, 2024
2695fd7
Check the correct location for the block.json
donnapep Aug 20, 2024
5a96809
Revert unrevert of Course Actions block
donnapep Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/revert-quiz-question-rendering
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Ensure quiz description is displayed to the student
10 changes: 4 additions & 6 deletions includes/blocks/class-sensei-block-quiz-question.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,16 @@ public function __construct() {
],
Sensei()->assets->src_path( 'blocks/quiz/question-block' )
);

Sensei_Blocks::register_sensei_block(
'sensei-lms/question-description',
[
'render_callback' => '__return_empty_string',
donnapep marked this conversation as resolved.
Show resolved Hide resolved
],
[],
Sensei()->assets->src_path( 'blocks/quiz/question-description-block' )
);

Sensei_Blocks::register_sensei_block(
'sensei-lms/question-answers',
[
'render_callback' => '__return_empty_string',
],
[],
Sensei()->assets->src_path( 'blocks/quiz/question-answers-block' )
);
}
Expand Down
2 changes: 1 addition & 1 deletion includes/blocks/class-sensei-block-quiz.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function __construct() {
[
'render_callback' => [ $this, 'render_quiz' ],
],
Sensei()->assets->src_path( 'blocks/quiz/quiz-block' )
donnapep marked this conversation as resolved.
Show resolved Hide resolved
Sensei()->assets->src_path( 'blocks/quiz' )
);
}

Expand Down
26 changes: 0 additions & 26 deletions includes/blocks/class-sensei-course-actions-block.php
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion includes/blocks/class-sensei-global-blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public function initialize_blocks() {
new Sensei_Course_Progress_Block();
new Sensei_Course_Overview_Block();
new Sensei_Course_List_Block();
new Sensei_Course_Actions_Block();
donnapep marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down
Loading