Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flipper support for Loop app #472

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Add Flipper support for Loop app #472

merged 3 commits into from
Jul 31, 2020

Conversation

aforcier
Copy link
Collaborator

(Stacked on top of #470 to prevent a conflict since I renamed the app in that PR.)

Adds support for Flipper, a runtime debugging tool, to the example app in debug.

(You've probably used Stetho in FluxC or WPAndroid - Flipper is a replacement for Stetho, and comes with a Mac binary as a debugging tool. There's an open PR in FluxC introducing Flipper there.)

I found it useful for being able to inspect layouts in realtime:

Screen Shot 2020-07-29 at 2 29 57 PM

There are other features like network interception and storage inspection but those aren't useful for this project, so I just enabled the layout inspector.

To test:

  1. Install the desktop app: https://www.facebook.com/fbflipper/public/mac and run it.
  2. Run the Loop app.
  3. Make sure the Flipper app connects to the device/emulator.
  4. Enable the layout inspector in the desktop app.
  5. Make sure you can inspect the layout.

More about Flipper here: https://fbflipper.com/

Base automatically changed from feature/rename-to-stories to develop July 29, 2020 12:41
@jd-alexander
Copy link
Contributor

@aforcier Nice addition! I assume this is ready for review now? I would assign to myself and do so 🙏

@aforcier
Copy link
Collaborator Author

Go for it @jd-alexander !

@aforcier aforcier requested a review from jd-alexander July 30, 2020 01:18
@aforcier
Copy link
Collaborator Author

Also just a note that there's an open issue for adding Flipper to WPAndroid as well: wordpress-mobile/WordPress-Android#11615

Though from a quick try I did a bit ago, it wasn't straightforward. I think there's a dependency conflict between the Flipper libraries and react native but I didn't spend much time on it.

@jd-alexander
Copy link
Contributor

Also just a note that there's an open issue for adding Flipper to WPAndroid as well: wordpress-mobile/WordPress-Android#11615
Though from a quick try I did a bit ago, it wasn't straightforward. I think there's a dependency conflict between the Flipper libraries and react native but I didn't spend much time on it.

Understood. Thanks for the note 🙇

Reviewing this now.

app/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

@jd-alexander jd-alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aforcier Tested and it works. I left a minor comment. But apart from that, this is good to go. LGTM 🚢

@aforcier aforcier merged commit 10a512f into develop Jul 31, 2020
@aforcier aforcier deleted the feature/flipper branch July 31, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants