-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flipper support for Loop app #472
Conversation
07efd73
to
183e3c2
Compare
@aforcier Nice addition! I assume this is ready for review now? I would assign to myself and do so 🙏 |
Go for it @jd-alexander ! |
Also just a note that there's an open issue for adding Flipper to WPAndroid as well: wordpress-mobile/WordPress-Android#11615 Though from a quick try I did a bit ago, it wasn't straightforward. I think there's a dependency conflict between the Flipper libraries and react native but I didn't spend much time on it. |
Understood. Thanks for the note 🙇 Reviewing this now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aforcier Tested and it works. I left a minor comment. But apart from that, this is good to go. LGTM 🚢
(Stacked on top of #470 to prevent a conflict since I renamed the app in that PR.)
Adds support for Flipper, a runtime debugging tool, to the example app in debug.
(You've probably used Stetho in FluxC or WPAndroid - Flipper is a replacement for Stetho, and comes with a Mac binary as a debugging tool. There's an open PR in FluxC introducing Flipper there.)
I found it useful for being able to inspect layouts in realtime:
There are other features like network interception and storage inspection but those aren't useful for this project, so I just enabled the layout inspector.
To test:
More about Flipper here: https://fbflipper.com/