Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining synthetics from ComposeLoopFrameActivity #687

Merged

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented May 20, 2021

Follow up to the merge of #634 with the updated base branch. The bottom opaque bar added in #651 was still using synthetics.

@mzorz mzorz marked this pull request as ready for review May 20, 2021 18:54
@mzorz mzorz requested a review from aforcier May 20, 2021 18:54
@mzorz mzorz added the [Type] Task Something that needs be done, but is not necessarily a feature/bugfix itself. label May 20, 2021
Copy link
Collaborator

@aforcier aforcier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@aforcier aforcier merged commit 3dd7242 into feature/view-binding May 21, 2021
@aforcier aforcier deleted the feature/view-binding-remove-remaining-synthetics branch May 21, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task Something that needs be done, but is not necessarily a feature/bugfix itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants