[Nullability Annotations to Java Classes] Update wordPressLintVersion to 2.0.0
#742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Notes: https://github.com/wordpress-mobile/ WordPress-Lint-Android/releases/tag/2.0.0
Since 'photoeditor' module is all Kotlin, with no Java file in it, there is no point in utilizing the 'org.wordpress:lint' on it. FYI: As of version '2.0.0' has only one rule, which informs about missing null annotation on Java classes.
Since 'app' module is still using Java files in it, it makes sense to utilize the 'org.wordpress:lint' on it. FYI: As of version '2.0.0' has only one rule, which informs about missing null annotation on Java classes.
wzieba
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
wordPressLintVersionto 2.0.0.FYI: Since
photoeditormodule is all Kotlin, with no Java files in it, there is no point in utilizing theorg.wordpress:lintlibrary on it. However, theappmodule is still using Java files in it, and as such, it makes sense to utilize theorg.wordpress:lintlibrary on it.To test:
MissingNullAnnotationOn*correctness related rules are reporting as expected. For a reference, see screenshot below:mp4composemodule:storiesmodule:appmodule: