[Fix] Update targetSdk to 34 and fixed a few issues along the way. #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically there was a foreground service type missing, and sentry needed to be updated.
notandyvee
added
the
[Type] Task
irfano
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
dataSync looks proper for FrameSaveService to me.
I only updated Sentry to the lowest possible version that avoided the crash.
Good call. There are still many versions between Sentry 5.01 and 6.32.0; yes, there is a risk. I checked changes between two versions, and I couldn't find any change that may affect us.
So, LGTM! 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #744
Parent: https://github.com/orgs/wordpress-mobile/projects/223
This PR updates the
targetSdkversion to 34. During testing, two issues were found:foregroundServiceType.Something to note. I used datasync as the foreground service type. This makes sense as we are processing the image and the camera does not need to be open for this. But feel free to make sure I chose the right foreground service type as a second pair of eyes.
Note:
I tested this with the sample app and Wordpress Android. Worked fine on both.