Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covr: Update theme and prepare for Dotorg submission #7816

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

beafialho
Copy link
Collaborator

@beafialho beafialho commented May 20, 2024

Changes from WordPress Playground:

  • Adds font and image in theme screenshot license
  • Adjusts some spacings in the templates
  • Fixes lack of spacing in header and query loops
  • Removes wrong tags

@beafialho beafialho changed the title Update theme covr Covr: Update theme and prepare for Dotorg submission May 20, 2024
@jasmussen
Copy link
Member

Also catching up with this one, there are some conflicts that need fixing, I can help with that. Just asking now whether this is still relevant or not!

@beafialho
Copy link
Collaborator Author

Yes, this one is still relevant 👍

@jasmussen
Copy link
Member

I made a local PR in #7951 that includes changes from this PR. Let's see if that other branch looks right, if yes we can close this one in favor of that.

@vcanales
Copy link
Contributor

@jasmussen @beafialho the same comment I made in #8016 (comment) applies:

The best way to ensure that PRs for previews work well is to get the latest code from GitHub, because we could have made changes to a theme without deploying them, which is what I think happened in this PR.

@beafialho would it be possible to create another PR following a workflow where the changes you make to the theme are made to the latest code stored GitHub? I'm asking because the conflicts we see here make it hard to determine what to keep. If you need any help figuring out a workflow that will make it easier to review your themes, please reach out to me here on in private!

@jasmussen
Copy link
Member

Unfortunately for both this and the other PRs, Bea is currently completely snowed under with work on Twenty Twenty-Five. She will not have time to redo these PRs. If there's anything you can do to help the work along, we'd sure appreciate it, otherwise these will need to wait, most likely, until after the 6.7 beta period in 4 weeks. That would be a shame.

@MaggieCabrera MaggieCabrera force-pushed the playground-changes-2024-05-20T15-43-14-702Z branch from 2086a0a to db35082 Compare August 30, 2024 15:03
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Preview changes

I've detected changes to the following themes in this PR: Covr.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the conflicts and this one is testing fine on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants