Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoter: add theme #7880

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Promoter: add theme #7880

merged 10 commits into from
Sep 5, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jun 20, 2024

Promoter has a simple structure and displays only the necessary information for a real portfolio. It's ready for designers, artists, architects, and creators to use.
Demo site

screenshot

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Preview changes

I've detected changes to the following themes in this PR: Promoter.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor

alaczek commented Aug 29, 2024

I'm seeing a few issues with this theme:

  • search and archive templates use custom query loop setting which leads to wrong results being displayed (there was an identical issue for Organizer - Organizer: Fix archive and search templates #8040).
  • there are no comments in the single post template.
  • single page template doesn't include page title.
  • on the homepage, if posts have no featured images, they stick to the line above, which looks off visually.
image

@MaggieCabrera MaggieCabrera added the Ready to launch Add this label if this is the first PR for a new theme label Sep 3, 2024
@henriqueiamarino
Copy link
Collaborator Author

I've updated the theme following @alaczek's feedback and added some diversity to my style variations.

@MaggieCabrera
Copy link
Contributor

I'm reviewing this and making some changes

Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some changes to make patterns into templates and fixed main tags and this is good to go!

@henriqueiamarino henriqueiamarino merged commit f830564 into trunk Sep 5, 2024
2 checks passed
@henriqueiamarino henriqueiamarino deleted the add/promoter branch September 5, 2024 08:37
@henriqueiamarino
Copy link
Collaborator Author

@MaggieCabrera, here's the demo content file.

promoter.WordPress.2024-09-12.xml.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants