Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add theme #7889

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Feature: add theme #7889

merged 7 commits into from
Sep 6, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jun 21, 2024

The Feature is a magazine theme focused on sizable typography and imagery to grow your blog posts, reviews, artwork, and news.
Demo site

screenshot

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Preview changes

I've detected changes to the following themes in this PR: Feature.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor

alaczek commented Aug 29, 2024

I found a few UX issues, similar to the Excerpts theme:

  • site title isn't included in the header.
  • the info about the theme and download in the footer doesn't make sense from the customer point of view. While it's true that customers can remove this via the editor, we also know it's quite hard to navigate for inexperienced users. We can keep that info on the demo page, but I recommend removing it from the theme.
image * Can the page-about.html template can be removed?

@MaggieCabrera MaggieCabrera added the Ready to launch Add this label if this is the first PR for a new theme label Sep 3, 2024
@henriqueiamarino henriqueiamarino requested review from jffng and removed request for jffng September 5, 2024 07:43
@MaggieCabrera
Copy link
Contributor

Is it ok to submit themes to .org using 3rd party blocks on the templates instead of the patterns? I don't have jetpack locally and I see a placeholder prompting me to install instead. I think this doesn't block the submission, but wanted to point it out

@henriqueiamarino henriqueiamarino merged commit 876b570 into trunk Sep 6, 2024
2 checks passed
@henriqueiamarino henriqueiamarino deleted the add/feature branch September 6, 2024 09:44
@henriqueiamarino
Copy link
Collaborator Author

@MaggieCabrera, here's the demo content file.

feature.WordPress.2024-09-12.xml.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants