-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise asset images on themes starting with A #8268
base: trunk
Are you sure you want to change the base?
Conversation
Preview changesI've detected changes to the following themes in this PR: Affinity, Al Dente, AlleyOop, Allez, Archeo.
I will update this comment with the latest preview links as you push more changes to this PR. |
Theme-Check resultsaffinity: There are required changes on the theme ❌.❎ REQUIRED
💡 RECOMMENDED (4)
|
Reviewers: please note that any issues above are pre-existing, as the only thing this PR does is optimise a few existing images. |
This PR optimises some of the images in themes starting with the letter
A
. The changes were generated usingImageOptim
, and images were visually inspected to ensure no obvious visual artefacts were introduced.These assets are either loaded by the theme directly (in the case of classic themes), or are part of patterns / templates in the case of block themes.
In the case of classic themes, the images will have a direct performance impact when they're loaded.
In the case of block themes, the images will only have a performance impact if the user does not replace them and does not upload them to their media library. So while they won't have an impact every time, it's still best to make the images smaller in the first place, as a form of mitigation.
Changes proposed in this Pull Request:
A