Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise asset images on themes starting with A #8268

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

sgomes
Copy link
Contributor

@sgomes sgomes commented Oct 15, 2024

This PR optimises some of the images in themes starting with the letter A. The changes were generated using ImageOptim, and images were visually inspected to ensure no obvious visual artefacts were introduced.

These assets are either loaded by the theme directly (in the case of classic themes), or are part of patterns / templates in the case of block themes.

In the case of classic themes, the images will have a direct performance impact when they're loaded.

In the case of block themes, the images will only have a performance impact if the user does not replace them and does not upload them to their media library. So while they won't have an impact every time, it's still best to make the images smaller in the first place, as a form of mitigation.

Changes proposed in this Pull Request:

  • Optimise image assets in themes starting with the letter A

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Affinity, Al Dente, AlleyOop, Allez, Archeo.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

affinity: There are required changes on the theme ❌.

❎ REQUIRED

  • Could not find wp_body_open action or function call at the very top of the body just after the opening body tag. See: wp_body_open
  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
  • Tested up to: is missing from your style.css header. Also, this should be numbers only, so 5.0 and not WP 5.0
  • Requires PHP: is missing from your style.css header.
💡 RECOMMENDED (4)
  • No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
  • No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
  • No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
  • No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.
⚠️ WARNING (4)
  • assets/img/autumn.jpg is 506.7 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
  • screenshot.png is 651.9 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Headings'. Line 26: __( 'Headings' ) );
  • Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Links'. Line 49: __( 'Links' ) );

aldente: No changes required ✅.

⚠️ WARNING (2)
  • screenshot.png is 932.9 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
  • Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme's correct slug and text-domain is al-dente. (If this is a child theme, you can ignore this error.)
💡 RECOMMENDED (1)
  • Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

alleyoop: No changes required ✅.


allez: There are required changes on the theme ❌.

❎ REQUIRED

  • Found a reference to unsplash.com. Assets from this website does not use a license that is compatible with GPL. View license (opens in a new window).
⚠️ WARNING (1)
  • screenshot.png is 1.2 MB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
💡 RECOMMENDED (1)
  • Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

archeo: No changes required ✅.

⚠️ WARNING (2)
  • assets/images/chahk.gif is 591.7 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
  • screenshot.jpg is 732.5 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.

@sgomes
Copy link
Contributor Author

sgomes commented Oct 15, 2024

Reviewers: please note that any issues above are pre-existing, as the only thing this PR does is optimise a few existing images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant