Rockfield: Fix cart button styles

[ouikhuan]

Changes proposed in this Pull Request:

This PR fixes the button styles in the Cart page for Proceed to checkout button and also remove the outline from the remove item link.

Before:

After:

Related issue(s):

#8467

[github-actions]

Preview changes

I've detected changes to the following themes in this PR: Rockfield.
You can preview these changes by following the links below:

• Preview changes for Rockfield (child of varia)

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

[ouikhuan]

Hi @Automattic/theam 👋 I'm working on this issue from GroundsKeeping rotation so first timer here! The PR is a CSS fix, but from the theme check above it seems to trigger quite a few error that's not related to the proposed fix, what would you suggest for us to move this forward?

[alaczek]

Could we style this button to match the theme?

I had a quick look at the failing checks, and I don't think we have to worry about this - I think they are looking for theme.json which this theme doesn't have as it's older.

[github-actions]

Theme-Check results

rockfield: There are required changes on the theme ❌.

❎ REQUIRED

• Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
• bump-version-numbers.sh rebuild-child-themes.sh Shell script file found. This file must not be in the production version of the theme.
• Tested up to: is missing from your style.css header. Also, this should be numbers only, so 5.0 and not WP 5.0
• Requires PHP: is missing from your style.css header.
• No reference to add_theme_support( "title-tag" ) was found in the theme.
• The theme appears to use dynamic_sidebars() but no register_sidebar() was found. See: register_sidebar

💡 RECOMMENDED (13)

• No reference to register_block_pattern was found in the theme. Theme authors are encouraged to implement custom block patterns as a transition to block themes.
• No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
• Could not find the comment-reply script enqueued.
• No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" ) in the functions.php file.
• .wp-caption css class is recommended in your theme css.
• .wp-caption-text css class is recommended in your theme css.
• No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
• No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
• No reference to add_theme_support( "custom-logo", $args ) was found in the theme. It is recommended that the theme implement this functionality.
• No reference to add_theme_support( "html5", $args ) was found in the theme. It is strongly recommended that the theme implement this functionality.
• No reference to add_theme_support( "responsive-embeds" ) was found in the theme. It is recommended that the theme implement this functionality.
• No reference to add_theme_support( "align-wide" ) was found in the theme. It is recommended that the theme implement this functionality.
• No reference to add_theme_support( "wp-block-styles" ) was found in the theme. It is recommended that the theme implement this functionality.

⚠️ WARNING (11)

• screenshot.png is 1.1 MB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors-css-variables.php. Function __, with the arguments 'Background Color'. Line 22: __( 'Background Color' )
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors-css-variables.php. Function __, with the arguments 'Foreground Color'. Line 38: __( 'Foreground Color' )
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors-css-variables.php. Function __, with the arguments 'Primary Color'. Line 54: __( 'Primary Color' )
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors-css-variables.php. Function __, with the arguments 'Secondary Color'. Line 70: __( 'Secondary Color' )
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors-css-variables.php. Function __, with the arguments 'Tertiary Color'. Line 86: __( 'Tertiary Color' )
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Background Color'. Line 90: ), __( 'Background Color' ) );
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Link Color'. Line 214: ), __( 'Link Color' ) );
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Text Color'. Line 364: ), __( 'Text Color' ) );
• Found a translation function that is missing a text-domain in the file inc/wpcom-colors.php. Function __, with the arguments 'Secondary Color'. Line 380: ), __( 'Secondary Color' ) );
• More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are rockfield, varia.

---

[ouikhuan]

I had a quick look at the failing checks, and I don't think we have to worry about this - I think they are looking for theme.json which this theme doesn't have as it's older.

Thanks for having a look @alaczek !

Could we style this button to match the theme?

Sure, I've updated the CSS so it's matching the theme style now and ready for re-review, could you have another look once you have some time? Thank you!

[alaczek]

This is looking good to me now. LGTM!