Skip to content

Commit

Permalink
Merge pull request #381 from Automattic/update/minimum-requirements
Browse files Browse the repository at this point in the history
Update minimum requirements and TODO template
  • Loading branch information
gudmdharalds authored Nov 2, 2023
2 parents 05f141e + eb19174 commit cd159ce
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 6 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ TODO:
- [ ] Added patch for [describe issue]
- [ ] Add/update tests -- unit/integrated/E2E (if needed)
- [ ] Ensure only one function/functionality is tested per test file.
- [ ] New/updated software requirements?
- [ ] Update README.md
- [ ] Update defines.php
- [ ] Add to, or update, `Scan run detail` report as applicable
- [ ] Check status of automated tests
- [ ] Ensure `PHPDoc` comments are up to date for functions added or altered
Expand All @@ -31,6 +34,9 @@ TODO:
- [ ] Add to, or update, `Scan run detail` report as applicable
- [ ] Add/update tests -- unit/integrated/E2E
- [ ] Ensure only one function/functionality is tested per test file.
- [ ] New/updated software requirements?
- [ ] Update README.md
- [ ] Update defines.php
- [ ] Ensure `PHPDoc` comments are up to date for functions added or altered
- [ ] Update repository documentation (README.md, RELEASING.md, TESTING.md, TOOLS-UPDATE.md)
- [ ] Assign appropriate [priority](https://github.com/Automattic/vip-go-ci/blob/trunk/CONTRIBUTING.md#priorities) and [type of change labels](https://github.com/Automattic/vip-go-ci/blob/trunk/CONTRIBUTING.md#type-of-change-labels).
Expand Down
4 changes: 2 additions & 2 deletions defines.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
/*
* Define minimum version requirements.
*/
define( 'VIPGOCI_GIT_VERSION_MINIMUM', '2.10' );
define( 'VIPGOCI_PHP_VERSION_MINIMUM', '7.3.0' );
define( 'VIPGOCI_GIT_VERSION_MINIMUM', '2.30' );
define( 'VIPGOCI_PHP_VERSION_MINIMUM', '8.0.0' );

/*
* Client-ID for HTTP requests.
Expand Down

0 comments on commit cd159ce

Please sign in to comment.