You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All testing functions should define variable types
All testing functions should call require_once() during setUp() stage to make the most of running tests in separate processes - this avoids problems with functions being declared multiple times.
Rename vipgoci_unittests_output_suppress() and vipgoci_unittests_output_unsuppress() so that they include _maybe_.
Some unit-tests are linked to a particular token holder, such as ResultsFilterCommentsToMaxTest.php - this should be avoided.
Common folder for helper functions; all unit/helper files should go to common/helper, and all integrations/IncludesForTests*.php files to the same folder.
Remove WordPress.Files.FileName and Squiz.Commenting.FileComment exceptions from .vipgoci_options and fix tests accordingly
Consistent naming of tests - ensure each test has a prefix consistent with the file were the tested function lives. These tests need updating:
We need to clean up the unit and integration test suites a bit, ensuring more consistency and making them easier to work with.
The following elements need to be worked on:
namespace Vipgoci\Tests\Unit
ornamespace Vipgoci\Tests\Integration
declare(strict_types=1)
@preserveGlobalState disabled
and@runTestsInSeparateProcesses
, explain inREADME.md
:void
as return typerequire_once()
duringsetUp()
stage to make the most of running tests in separate processes - this avoids problems with functions being declared multiple times.phpcs:disable PSR1.Files.SideEffects
from testsSkeleton.php
files follow all the above.vipgoci_unittests_output_suppress()
andvipgoci_unittests_output_unsuppress()
so that they include_maybe_
.ResultsFilterCommentsToMaxTest.php
- this should be avoided.unit/helper
files should go tocommon/helper
, and allintegrations/IncludesForTests*.php
files to the same folder.WordPress.Files.FileName
andSquiz.Commenting.FileComment
exceptions from.vipgoci_options
and fix tests accordinglyThe text was updated successfully, but these errors were encountered: