Skip to content
This repository has been archived by the owner on Jul 20, 2018. It is now read-only.

Apply a filter to the WP.com checks config #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehg
Copy link
Member

@ehg ehg commented Aug 15, 2014

This is so we can filter out checks that won't work with the .zip scanner on
WP.com yet, whilst keeping one .com config, so we're not maintaining two lists.

This is so we can filter out checks that won't work with the scanner on
WP.com yet.
@joshbetz
Copy link
Contributor

joshbetz commented Sep 5, 2014

Would it be better to do this inside register_review() so we have it for every review type and not just WP.com reviews? You'd probably also want to pass in the review type in that case.

@nickdaugherty
Copy link
Contributor

This is actually already supported by this:

apply_filters( 'vip_scanner_run_check', true, $check )

https://github.com/Automattic/vip-scanner/blob/master/vip-scanner/class-base-scanner.php#L234

Does that solve your use case?

@nb
Copy link
Member

nb commented Nov 24, 2014

Ping @ehg

@ehg
Copy link
Member Author

ehg commented Nov 25, 2014

Oops, over-zealous GMail filtering meant I didn't notice any notifications for this until I checked in the Github UI!

@nickdaugherty the vip_scanner_run_check would probably suit us, if it didn't add a skipped test error to the log. Maybe we could add a silent flag for that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants