Mark customize store task complete when user redirects to the site ed… #1307
Conversation
…itor from a theme details page
|
Size Change: 0 B Total Size: 196 kB ℹ️ View Unchanged
|
… is set from wp-calypso
There was a problem hiding this comment.
It's looking nice @moon0326 , thank you! It tested well and I left a couple of suggestions to consider.
Pre-approving! 🚀
For other reviewers: I used my local wp-env site to test the PR and confirmed the option with wp-env run cli wp option get woocommerce_admin_customize_store_completed
| private function __construct() { | ||
|
|
||
| // Only in Ecommerce or Free Trial | ||
| if ( ! wc_calypso_bridge_has_ecommerce_features() && ! wc_calypso_bridge_is_ecommerce_trial_plan() ) { |
There was a problem hiding this comment.
How about checking the feature flag instead? I think it would keep us in sync with the planned rollout without needing to make changes in the future. The rollout currently looks like:
October: Woo Express only
December: Everywhere (Core, all WP.com hosted plans)
Between Oct-Dec, e-commerce plans could still be used for testing by changing the feature flag on the site.
There was a problem hiding this comment.
Sounds good 👍 I'll make an update.
There was a problem hiding this comment.
wp-env run cli wp option get woocommerce_admin_customize_store_completed
I always forget we have access to CLI in WoA dev site :) Thank you for the tip 👍
There was a problem hiding this comment.
@adrianduffell Updated in dee4b25
Could you run the test again, please? I've also updated the test instructions.
There was a problem hiding this comment.
Thanks @moon0326 -- I tested it again and it's all working nice!
…itor from a theme details page
Changes proposed in this Pull Request:
Closes https://github.com/woocommerce/team-ghidorah/issues/264
How to test the changes in this Pull Request:
customize-storefeature flag fromTools -> WCA Test Helper -> Featureswoocommerce_admin_customize_store_completedoption is set toyesFor step 4, you can install
SQL Executionerplugin and run the following query.select * from wp_options where option_name = 'woocommerce_admin_customize_store_completed'Other information:
FOR PR REVIEWER ONLY: