Add filter for recommended WPCOM themes

[crunnells]

Changes proposed in this Pull Request:

Adds a filter to change the recommended themes for Woo Express sites on WPCOM.

Closes #1316.

How to test the changes in this Pull Request:

• Have you followed the Writing high-quality testing instructions guide?

1. Follow the instructions to setup a Woo Express site to test CYS: pdibGW-2pG-p2
2. Update the wc-calypso-bridge plugin with this branch.
3. Visit My Home in wp-admin and click "Customize Your Store"
4. The Intro page will show 4 themes; confirm that the site URL is appended to the theme links, eg: https://wordpress.com/theme/tazza/yourblog.com
5. Activate one of the recommended themes (Tsubaki, Tazza, Amulet, or Zaino) via the Themes showcase
6. Re-visit the "Customize Your Store" page and confirm that active theme is marked as such:

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

• I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

[github-actions]

Size Change: 0 B

Total Size: 196 kB

ℹ️ View Unchanged

Filename	Size
./build/53.js	1.05 kB
./build/index.css	883 B
./build/index.js	121 kB
./build/marketing.js	58 kB
./build/payment-gateway-suggestions.css	1.25 kB
./build/payment-gateway-suggestions.js	6.45 kB
./build/plugins.js	3.92 kB
./build/style-index.css	2 kB
./build/style-marketing.css	805 B

_{compressed-size-action}

[moon0326]

Thank you for working on it 👍

LGTM and tested well with an ECOM plan. @chihsuan Do we also need to use this filter in trial mode?

[chihsuan]

LGTM and tested well with an ECOM plan. @chihsuan Do we also need to use this filter in trial mode?

Yes. 🙂

[adrianduffell]

LGTM, nice work @crunnells !

[moon0326]

@crunnells As confirmed by @chihsuan, we also need to run the hook for free trials. What do you think about creating a new class (e.g., class-wc-calypso-bridge-cys-themes.php) to customize the list for both trial and econ plans? You can include the new class in https://github.com/Automattic/wc-calypso-bridge/blob/master/class-wc-calypso-bridge.php#L100. You can check for free trial plan with wc_calypso_bridge_is_ecommerce_trial_plan function.

@adrianduffell Do you think we have a different (or possibly better) approach?

[crunnells]

As confirmed by @chihsuan, we also need to run the hook for free trials. What do you think about creating a new class (e.g., class-wc-calypso-bridge-cys-themes.php) to customize the list for both trial and econ plans?

Do we restrict which themes free trial accounts can use and activate?

[moon0326]

As confirmed by @chihsuan, we also need to run the hook for free trials. What do you think about creating a new class (e.g., class-wc-calypso-bridge-cys-themes.php) to customize the list for both trial and econ plans?

Do we restrict which themes free trial accounts can use and activate?

I don't think we need to restrict the themes. @chihsuan @adrianduffell Could you confirm please?

[moon0326]

@crunnells As confirmed by @chihsuan, we also need to run the hook for free trials. What do you think about creating a new class (e.g., class-wc-calypso-bridge-cys-themes.php) to customize the list for both trial and econ plans? You can include the new class in https://github.com/Automattic/wc-calypso-bridge/blob/master/class-wc-calypso-bridge.php#L100. You can check for free trial plan with wc_calypso_bridge_is_ecommerce_trial_plan function.

@adrianduffell Do you think we have a different (or possibly better) approach?

This is actually not correct.

wc-calypso-bridge/includes/class-wc-calypso-bridge-filters.php

Line 40 in 35bb9b2

if ( ! wc_calypso_bridge_has_ecommerce_features() ) {

checked for both econ and econ trial plans.

Sorry for the false alarm 🙏

[moon0326]

LGTM and tested well 👍 🚀

[chihsuan]

I don't think we need to restrict the themes. @chihsuan @adrianduffell Could you confirm please?

Thanks for the ping. We don't need to restrict the themes! 🙂