Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Orders" menu position when using HPOS #1330

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

xristos3490
Copy link
Member

@xristos3490 xristos3490 commented Oct 23, 2023

Specification

This pull request aims to fix the Orders menu item in HPOS by repositioning the menu, highlighting it correctly, and re-adding the familiar bubble with the number of orders needing processing.

Closes #1326 , closes #1325

Validation

  1. Visit a WX site.
  2. Navigate to Settings > WooCommerce > Advanced > Features and ensure that HPOS is enabled; if not, enable it.
  3. Refresh the page and notice the "WooCommerce > Orders" menu item (along with a top-level "Orders" menu that points to the CPT.)
  4. Apply this patch.
  5. Notice that the "Orders" menu item appears on the top level.
  6. Navigate to "Orders > Orders" and "Orders > Add New" to ensure that the menu highlighting works as expected.

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Size Change: 0 B

Total Size: 196 kB

ℹ️ View Unchanged
Filename Size
./build/53.js 1.05 kB
./build/index.css 883 B
./build/index.js 121 kB
./build/marketing.js 58 kB
./build/payment-gateway-suggestions.css 1.25 kB
./build/payment-gateway-suggestions.js 6.45 kB
./build/plugins.js 3.92 kB
./build/style-index.css 2 kB
./build/style-marketing.css 805 B

compressed-size-action

Copy link
Contributor

@jimjasson jimjasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xristos3490,

I tested this PR and confirmed that after your changes, when HPOS is used:

  • The additional Extensions > Orders tab is removed and;
  • The Orders menu item points to the correct wc-order URL.

Copy link
Contributor

@PanosSynetos PanosSynetos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested with @jimjasson and code reviewed (pushed a commit to avoid back and forths)

Thanks for this - awesome! Merging and will ship later in the day

@PanosSynetos PanosSynetos merged commit 70ccaf3 into master Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the "Orders" menu position when using HPOS Clicking "Orders > Add New" opens wrong menu item
3 participants