Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide launch banner when viewing iframe from the intro screen #1348

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Nov 3, 2023

Changes proposed in this Pull Request:

This PR removes launch banner from the CYS intro screen iframe:

image

How to test the changes in this Pull Request:

  1. Set up a latest WordPress according to this guide: p6q8Tx-3Je-p2
  2. Make sure to enable customize-store feature flag
  3. Make sure your site is in "coming soon" mode in Settings > General > Privacy
  4. Go to https://yoursite/?cys-hide-admin-bar
  5. Observe that the launch banner is no longer shown
image

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Copy link

github-actions bot commented Nov 3, 2023

Size Change: 0 B

Total Size: 196 kB

ℹ️ View Unchanged
Filename Size
./build/53.js 1.05 kB
./build/index.css 883 B
./build/index.js 121 kB
./build/marketing.js 58 kB
./build/payment-gateway-suggestions.css 1.25 kB
./build/payment-gateway-suggestions.js 6.45 kB
./build/plugins.js 3.92 kB
./build/style-index.css 2 kB
./build/style-marketing.css 805 B

compressed-size-action

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works perfectly, thanks @ilyasfoo ! 🚀

@ilyasfoo ilyasfoo merged commit 34bfe7a into master Nov 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants