Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LYS badge from WPCOM sites #1519

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

ilyasfoo
Copy link
Contributor

@ilyasfoo ilyasfoo commented Sep 24, 2024

Changes proposed in this Pull Request:

p1727162923759179/1726818329.636839-slack-C06DJHTE04U

Since WPCOM has coming soon badge shown in sidebar when in coming soon mode, LYS coming soon badge is redundant.

image

How to test the changes in this Pull Request:

  1. Use a WPCOM atomic e-commerce site
  2. Enable LYS feature flag (you can set these lines to true).
  3. Go to Settings > WooCommerce > Site visibility
  4. Set to Coming soon and save
  5. Confirm site visibility badge is not shown

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested review from a team, psealock and moon0326 September 24, 2024 10:01
Copy link

github-actions bot commented Sep 24, 2024

Size Change: 0 B

Total Size: 201 kB

ℹ️ View Unchanged
Filename Size
./build/53.js 1.08 kB
./build/index.css 731 B
./build/index.js 126 kB
./build/marketing.js 58.3 kB
./build/payment-gateway-suggestions.css 1.24 kB
./build/payment-gateway-suggestions.js 6.57 kB
./build/plugins.js 3.93 kB
./build/style-index.css 2.15 kB
./build/style-marketing.css 800 B

compressed-size-action

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

@ilyasfoo ilyasfoo merged commit 7d0e90f into master Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants