Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove launch-your-store feature flag override #1521

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

ilyasfoo
Copy link
Contributor

Changes proposed in this Pull Request:

P2: pfwcF5-Cs-p2

In order to enable launch-your-store feature in WPCOM sites, we need to remove the feature flag override.

How to test the changes in this Pull Request:

  1. Use a WPCOM atomic e-commerce site
  2. Go to Settings > WooCommerce > Site visibility
  3. In an incognito window, open up site's frontend
  4. Observe LYS branded coming soon page is displayed
  5. Set to Coming soon and save
  6. Open up /_cli in a new tab
  7. Run plugin install --activate https://github.com/woocommerce/woocommerce/releases/download/wc-beta-tester-2.4.0/woocommerce-beta-tester.zip to install WCA Test Helper plugin
  8. Go to Tools > WCA Test Helper > Features
  9. Disable Launch your store
  10. In an incognito window, open up site's frontend
  11. Observe WPCOM branded coming soon page is displayed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@ilyasfoo ilyasfoo requested review from a team, psealock and moon0326 September 25, 2024 03:48
Copy link

Size Change: 0 B

Total Size: 201 kB

ℹ️ View Unchanged
Filename Size
./build/53.js 1.08 kB
./build/index.css 731 B
./build/index.js 126 kB
./build/marketing.js 58.3 kB
./build/payment-gateway-suggestions.css 1.24 kB
./build/payment-gateway-suggestions.js 6.57 kB
./build/plugins.js 3.93 kB
./build/style-index.css 2.15 kB
./build/style-marketing.css 800 B

compressed-size-action

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

@ilyasfoo ilyasfoo merged commit 7b814e1 into master Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants