Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Updates: Allow unlimited update schedules #90212

Merged
merged 3 commits into from
May 6, 2024

Conversation

TimBroddin
Copy link
Contributor

@TimBroddin TimBroddin commented May 2, 2024

Warning

Only merge this after a new version of jetpack-mu-wpcom is released

Related to #89793

Proposed Changes

  • Frontend changes to allow up to 24 updates.
image

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@TimBroddin TimBroddin requested a review from a team May 2, 2024 13:39
@TimBroddin TimBroddin self-assigned this May 2, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 2, 2024
@matticbot
Copy link
Contributor

matticbot commented May 2, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~28 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
plugins                               -120 B  (-0.0%)      -28 B  (-0.0%)
jetpack-cloud-plugin-management       -120 B  (-0.0%)      -28 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/scheduled-updates-raise-limit on your sandbox.

Copy link
Contributor

@zaerl zaerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TimBroddin TimBroddin changed the title Scheduled Updates: Allow up to 24 updates Scheduled Updates: Allow unlimited update schedules May 3, 2024
@TimBroddin TimBroddin requested a review from obenland May 3, 2024 08:01
@TimBroddin TimBroddin merged commit 5e91c7e into trunk May 6, 2024
11 checks passed
@TimBroddin TimBroddin deleted the add/scheduled-updates-raise-limit branch May 6, 2024 07:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants