-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow Help Center styles in wp-admin and Gutenberg #93628
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~240 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…calypso into fix/help-center-in-shadow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes!
I have tested many routes desktop, mobile, wp-admin. All worked fine. Haven't seen anything off or wrong.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested wp-admin and the editor and I didn't find any issue!
This reverts commit a0a8bf7.
Proposed Changes
This wraps the Help Center in a shadow root to prevent styles from leaking in and out of the Help Center.
Why are these changes being made?
The Help Center styles can break a few things and be broken by a few things because the Help Center runs in many places under several environments.
Testing Instructions
apps/help-center
runyarn dev --sync
.Next
Once this is live. We can merge this