Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@automattic/launchpad: Add missing dependencies #95431

Merged
merged 41 commits into from
Oct 21, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Oct 16, 2024

Related to Automattic/jetpack#39806

Proposed Changes

  • Add missing dependencies of the package so it can be used outside of Calypso (e.g.: Jetpack)

TODO:

Publish the following packages after merging

Why are these changes being made?

  • Make the package available outside of Calypso

Testing Instructions

  • Create a new sites
  • Finish the onboarding flow
  • When you land on the Launchpad, make sure it works as before
  • Go to /home/<your_site>
  • Make sure the Launchpad on My Home works as before as well

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Oct 16, 2024
@matticbot
Copy link
Contributor

matticbot commented Oct 16, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/make-launchpad-pkg-in-jetpack on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Oct 16, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~9 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper                +30 B  (+0.0%)       -9 B  (-0.0%)
entry-main                   +30 B  (+0.0%)       -9 B  (-0.0%)
entry-subscriptions          +20 B  (+0.0%)       -4 B  (-0.0%)
entry-login                  +20 B  (+0.0%)       -4 B  (-0.0%)
entry-domains-landing        +20 B  (+0.0%)       -4 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~132 bytes removed 📉 [gzipped])

name                           parsed_size           gzip_size
subscribers                          +59 B  (+0.0%)       +2 B  (+0.0%)
write-flow                           +49 B  (+0.0%)       -4 B  (-0.0%)
videopress-flow                      +49 B  (+0.0%)       -6 B  (-0.0%)
transferring-hosted-site-flow        +49 B  (+0.0%)      -26 B  (-0.1%)
link-in-bio-tld-flow                 +49 B  (+0.0%)      -19 B  (-0.0%)
home                                 +49 B  (+0.0%)      -32 B  (-0.0%)
earn                                 +49 B  (+0.0%)      -25 B  (-0.0%)
build-flow                           +49 B  (+0.0%)       -5 B  (-0.0%)
people                               +14 B  (+0.0%)       -2 B  (-0.0%)
reader                               -11 B  (-0.0%)       +0 B
jetpack-cloud-overview               -11 B  (-0.0%)       +9 B  (+0.0%)
a8c-for-agencies-overview            -11 B  (-0.0%)       +9 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~38 bytes removed 📉 [gzipped])

name                                                 parsed_size           gzip_size
async-load-masterbar-launchpad-navigator                   +49 B  (+0.1%)      -29 B  (-0.1%)
async-load-calypso-my-sites-stats-pages-subscribers        +49 B  (+0.0%)      -20 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 requested a review from a team as a code owner October 17, 2024 09:53
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 17, 2024
@arthur791004 arthur791004 force-pushed the feat/make-launchpad-pkg-in-jetpack branch from 0b64fac to df66ca9 Compare October 18, 2024 06:23
@arthur791004 arthur791004 requested a review from a team October 18, 2024 07:37
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested the following, using a new site with Build intent:

✅ The full-screen launchpad is shown correctly.
✅ I can complete a task from the full-screen launchpad.
✅ The My Home launchpad is shown correctly.
✅ I can complete a task from My Home launchpad.
✅ I can complete the task list (until Launch your site), and it gives me another set of tasks post-launch.

@arthur791004 arthur791004 merged commit eab5831 into trunk Oct 21, 2024
12 checks passed
@arthur791004 arthur791004 deleted the feat/make-launchpad-pkg-in-jetpack branch October 21, 2024 02:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants