-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@automattic/launchpad: Add missing dependencies #95431
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~9 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~132 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~38 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
0b64fac
to
df66ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke-tested the following, using a new site with Build intent:
✅ The full-screen launchpad is shown correctly.
✅ I can complete a task from the full-screen launchpad.
✅ The My Home launchpad is shown correctly.
✅ I can complete a task from My Home launchpad.
✅ I can complete the task list (until Launch your site
), and it gives me another set of tasks post-launch.
Related to Automattic/jetpack#39806
Proposed Changes
TODO:
Publish the following packages after merging
@automattic/[email protected]
@automattic/[email protected]
@automattic/[email protected]
@automattic/[email protected]
@automattic/[email protected]
@automattic/[email protected]
@automattic/[email protected]
@automattic/[email protected]
Why are these changes being made?
Testing Instructions
/home/<your_site>
Pre-merge Checklist