-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goals and DP first: Move DIFM intro before account #97749
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~211 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~150 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I made the changes below:
|
e85c8e5
to
442ee81
Compare
442ee81
to
adc3a96
Compare
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
adc3a96
to
02ae083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, I was able to go through the DIFM flow from the Goal first screen.
* Goals and DP first: Move DIFM intro before account * Goals First: Support backUrl and preselected choice for the DIFM steps * Goals First: Support Use an existing site for logged-in users on the DIFM screen * Fix tests * Don't show site choice if there is a selected site * Display back button on the DIFM for the site-setup flow * Fix styles * Fix types * Add back_to to the loginUrl --------- Co-authored-by: arthur <[email protected]>
Closes #97466.
Proposed Changes
Show the DIFM intro step before redirecting the user to account creation.
Why are these changes being made?
So there's more context about DIFM before showing the user the sign up step.
Testing Instructions
/setup/onboarding