Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals and DP first: Move DIFM intro before account #97749

Merged
merged 9 commits into from
Dec 24, 2024

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Dec 23, 2024

Closes #97466.

Proposed Changes

Show the DIFM intro step before redirecting the user to account creation.

Why are these changes being made?

So there's more context about DIFM before showing the user the sign up step.

Testing Instructions

  1. Enter /setup/onboarding
  2. Click the "Let us build a custom site for you" link
  • Verify you see the DIFM intro screen and click "Get started"
  • Verify you get redirected to the login screen
  • Verify you enter the DIFM flow after signing in

@zaguiini zaguiini requested a review from a team December 23, 2024 21:52
@zaguiini zaguiini self-assigned this Dec 23, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 23, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 23, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~211 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
onboarding-flow            +506 B  (+0.5%)     +165 B  (+1.3%)
update-design-flow         +122 B  (+0.0%)      +16 B  (+0.0%)
signup                     +122 B  (+0.0%)      +16 B  (+0.0%)
link-in-bio-tld-flow       +122 B  (+0.0%)      +16 B  (+0.0%)
site-setup-wg               +97 B  (+0.0%)      +30 B  (+0.0%)
site-setup-flow             +97 B  (+0.0%)      +30 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~150 bytes added 📈 [gzipped])

name                                          parsed_size           gzip_size
async-load-signup-steps-new-or-existing-site       +184 B  (+0.3%)      +70 B  (+0.3%)
async-load-signup-steps-difm-site-picker            +68 B  (+0.0%)      +52 B  (+0.1%)
async-load-signup-steps-site-options                +43 B  (+0.1%)      +28 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004
Copy link
Contributor

arthur791004 commented Dec 24, 2024

I made the changes below:

  • Use the back_to parameter to allow users to go back to the DIFM starting point of the onboarding flow
  • Use the newOrExistingSiteChoice parameter to allow the first step of the DIFM to support pre-selected choice to go to the corresponding next step directly
  • Display Use existing sites on the DIFM starting point of the onboarding flow for the logged-in users if there is no selected site.
  • Fix some styles

@arthur791004 arthur791004 self-assigned this Dec 24, 2024
@arthur791004 arthur791004 force-pushed the goals-first/difm-intro-first branch from e85c8e5 to 442ee81 Compare December 24, 2024 09:17
@zaguiini zaguiini force-pushed the goals-first/difm-intro-first branch from 442ee81 to adc3a96 Compare December 24, 2024 14:39
@zaguiini zaguiini marked this pull request as ready for review December 24, 2024 14:39
@zaguiini zaguiini requested a review from a team as a code owner December 24, 2024 14:39
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug goals-first/difm-intro-first on your sandbox.

@zaguiini zaguiini force-pushed the goals-first/difm-intro-first branch from adc3a96 to 02ae083 Compare December 24, 2024 16:55
Copy link
Contributor

@vykes-mac vykes-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, I was able to go through the DIFM flow from the Goal first screen.

@zaguiini zaguiini merged commit c94114f into trunk Dec 24, 2024
11 checks passed
@zaguiini zaguiini deleted the goals-first/difm-intro-first branch December 24, 2024 18:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 24, 2024
candy02058912 pushed a commit that referenced this pull request Dec 25, 2024
* Goals and DP first: Move DIFM intro before account

* Goals First: Support backUrl and preselected choice for the DIFM steps

* Goals First: Support Use an existing site for logged-in users on the DIFM screen

* Fix tests

* Don't show site choice if there is a selected site

* Display back button on the DIFM for the site-setup flow

* Fix styles

* Fix types

* Add back_to to the loginUrl

---------

Co-authored-by: arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: i2 Implement DIFM flow with an "Intro screen" before the Account page
4 participants