Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Style Variations: Filter out the colors and fonts" #97807

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Dec 27, 2024

Reverts #97795 since some of the themes only have colors..., e.g.: Bedrock

image

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-97795-feat/style-variations-filter-out-colors-and-fonts on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~26 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions          -98 B  (-0.0%)      -26 B  (-0.0%)
entry-stepper                -98 B  (-0.0%)      -26 B  (-0.0%)
entry-main                   -98 B  (-0.0%)      -26 B  (-0.0%)
entry-login                  -98 B  (-0.0%)      -26 B  (-0.0%)
entry-domains-landing        -98 B  (-0.0%)      -26 B  (-0.0%)
entry-browsehappy            -98 B  (-0.0%)      -26 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~183 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
patterns       -346 B  (-0.0%)     -162 B  (-0.0%)
theme           -80 B  (-0.0%)      -21 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1939 bytes added 📈 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-automattic-global-styles-src-components-global-styles-variations       -529 B  (-0.0%)     -549 B  (-0.1%)
async-load-automattic-design-preview                                              -503 B  (-0.0%)    -1165 B  (-0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 merged commit edad245 into trunk Dec 27, 2024
11 of 13 checks passed
@arthur791004 arthur791004 deleted the revert-97795-feat/style-variations-filter-out-colors-and-fonts branch December 27, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants