Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

AMP-CLIv0.1 #32

Merged
merged 4 commits into from
Mar 6, 2022
Merged

AMP-CLIv0.1 #32

merged 4 commits into from
Mar 6, 2022

Conversation

alanssitis
Copy link
Contributor

@alanssitis alanssitis commented Feb 28, 2022

What is a quick description of the change?

Implementation of AMP-CLI. Should be considered as a beta-release for testing.

Is this fixing an issue?

Close #19

Were any issues created as a result of this change?

#30 and #31

Are there more details that are relevant?

Check lists (check x in [ ] of list items)

For each of these items, please refer to the software style guide

  • Coding style

Any additional comments?

None

@alanssitis alanssitis force-pushed the cli-test branch 2 times, most recently from 64ef3a0 to 6409bf7 Compare March 1, 2022 00:35
@alanssitis
Copy link
Contributor Author

@zghera @Reschivon Could any of you review this PR? I will need some of these docker images in order to work on the CI pipeline for building.

@alanssitis alanssitis self-assigned this Mar 4, 2022
@alanssitis alanssitis added enhancement New feature or request tooling Workflow, CI/CD, and related tooling work for the ASS. labels Mar 4, 2022
Copy link
Member

@zghera zghera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why I am unable to run amp-cli with either the commands (devel or scratch). I am in fact logged in because I am able to run the hello-world container. See below:

(amp-v2) z:~/Documents/AMP_ASSv2(cli-test)$ amp-cli devel
Running amp-devel:frame-desktop...
Error: 404 Client Error for http+docker://localhost/v1.41/images/create?tag=frame-desktop&fromImage=amp-devel: Not Found ("pull access denied for amp-devel, repository does not exist or may require 'docker login': denied: requested access to the resource is denied")
(amp-v2) z:~/Documents/AMP_ASSv2(cli-test)$ docker run hello-world
Unable to find image 'hello-world:latest' locally
latest: Pulling from library/hello-world
2db29710123e: Already exists 
Digest: sha256:97a379f4f88575512824f3b352bc03cd75e239179eea0fecc38e597b2209f49a
Status: Downloaded newer image for hello-world:latest

Hello from Docker!
This message shows that your installation appears to be working correctly.

...

Maybe I am missing something trivial here as I am not super familiar with docker. Please let me know how I can help to troubleshoot! :)

setup.py Show resolved Hide resolved
@alanssitis
Copy link
Contributor Author

Try running it with the build flag!

@zghera
Copy link
Member

zghera commented Mar 6, 2022

Try running it with the build flag!

Ahhhhh, it seems to be building now! I probably should have ran amp-cli devel --help, silly me. Is there any way you could catch that exception in your code and advise the user to run with --help or --build in case someone forgets like me?

@alanssitis alanssitis force-pushed the cli-test branch 3 times, most recently from ace1a14 to 642d52b Compare March 6, 2022 17:57
@Reschivon
Copy link
Contributor

Looks good to me!

Copy link
Member

@zghera zghera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alanssitis alanssitis merged commit 939611d into master Mar 6, 2022
@alanssitis alanssitis deleted the cli-test branch March 6, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request tooling Workflow, CI/CD, and related tooling work for the ASS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of Software CLI tool
3 participants