-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
64ef3a0
to
6409bf7
Compare
@zghera @Reschivon Could any of you review this PR? I will need some of these docker images in order to work on the CI pipeline for building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure why I am unable to run amp-cli
with either the commands (devel or scratch). I am in fact logged in because I am able to run the hello-world container. See below:
(amp-v2) z:~/Documents/AMP_ASSv2(cli-test)$ amp-cli devel
Running amp-devel:frame-desktop...
Error: 404 Client Error for http+docker://localhost/v1.41/images/create?tag=frame-desktop&fromImage=amp-devel: Not Found ("pull access denied for amp-devel, repository does not exist or may require 'docker login': denied: requested access to the resource is denied")
(amp-v2) z:~/Documents/AMP_ASSv2(cli-test)$ docker run hello-world
Unable to find image 'hello-world:latest' locally
latest: Pulling from library/hello-world
2db29710123e: Already exists
Digest: sha256:97a379f4f88575512824f3b352bc03cd75e239179eea0fecc38e597b2209f49a
Status: Downloaded newer image for hello-world:latest
Hello from Docker!
This message shows that your installation appears to be working correctly.
...
Maybe I am missing something trivial here as I am not super familiar with docker. Please let me know how I can help to troubleshoot! :)
Try running it with the build flag! |
Ahhhhh, it seems to be building now! I probably should have ran |
ace1a14
to
642d52b
Compare
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is a quick description of the change?
Implementation of AMP-CLI. Should be considered as a beta-release for testing.
Is this fixing an issue?
Close #19
Were any issues created as a result of this change?
#30 and #31
Are there more details that are relevant?
Check lists (check x in [ ] of list items)
For each of these items, please refer to the software style guide
Any additional comments?
None