Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#1170 factorize installation contributing doc #1175

Merged

Conversation

jrobinAV
Copy link
Member

@jrobinAV jrobinAV commented Oct 21, 2024

resolves issue #1170

Should be reviewed along with Avaiga/taipy#2092

The PR:

  • updates the fetch so the INSTALLATION.md, CONTRIBUTING.md, and CODE_OF_CONDUCT.md are copied.
  • turns the installation page, the contributing page and the code of conduct page into templates, so the content is directly injected from the files in taipy repository
  • creates a new Step instantiated three times to re-use the content from taipy.

Note: The changes on gitignore will be reverted once merged. Indeed, the installation.md file must be removed from origin. Once it is removed, we can ignore it again.

@jrobinAV jrobinAV self-assigned this Oct 21, 2024
@jrobinAV jrobinAV added 📄 Documentation Internal or public documentation 🟨 Priority: Medium Not blocking but should be fixed soon labels Oct 21, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jrobinAV jrobinAV merged commit 9cf64ae into develop Oct 23, 2024
1 check passed
@jrobinAV jrobinAV deleted the feature/#1170-factorize-installation-contributing-doc branch October 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 Documentation Internal or public documentation 🟨 Priority: Medium Not blocking but should be fixed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants