Skip to content

Commit

Permalink
Per Fab's comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Fred Lefévère-Laoide authored and Fred Lefévère-Laoide committed Dec 27, 2022
1 parent 38faeea commit 6ad5065
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion core/l10n/bundle.l10n.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"Do you really want to definitely delete {0}:{1} from the configuration ?": "Do you really want to definitely delete {0}:{1} from the configuration ?",
"Do you really want to permanently delete {0}:{1} from the configuration?": "Do you really want to permanently delete {0}:{1} from the configuration?",
"Cannot show a {0} entity in a {1} Perpective.": "Cannot show a {0} entity in a {1} Perpective.",
"Entity {0} Name should not contain space, '.' or be empty or be default '{1}'": "Entity {0} Name should not contain space, '.' or be empty or be default '{1}'",
"Another {0} entity has the name {1}": "Another {0} entity has the name {1}",
Expand Down
2 changes: 1 addition & 1 deletion core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@
},
{
"command": "taipy.config.deleteNode",
"when": "view == taipy-config-datanodes || view == taipy-config-tasks || view == taipy-config-pipelines || view == taipy-config-scenarios"
"when": "view =~ /taipy-config-(datanodes|tasks|pipelines|scenarios)/"
},
{
"command": "taipy.config.revealInExplorer",
Expand Down
2 changes: 1 addition & 1 deletion core/src/editors/ConfigEditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export class ConfigEditorProvider implements CustomTextEditorProvider {
private async deleteConfigurationNode(item: TreeItem) {
const nodeType = item.contextValue;
const nodeName = item.label as string;
const answer = await window.showWarningMessage(l10n.t("Do you really want to definitely delete {0}:{1} from the configuration ?", nodeType, nodeName), "Yes", "No");
const answer = await window.showWarningMessage(l10n.t("Do you really want to permanently delete {0}:{1} from the configuration?", nodeType, nodeName.toLowerCase()), "Yes", "No");
if (answer === "Yes") {
const uri = getOriginalUri(item.resourceUri);
const realDocument = await this.taipyContext.getDocFromUri(uri);
Expand Down

0 comments on commit 6ad5065

Please sign in to comment.