Skip to content

Commit

Permalink
Add Acceptance Criteria (#1392)
Browse files Browse the repository at this point in the history
* Change required fields and markdown for screenshots

- Screenshot field is now Markdown
- Required fields changed
- Make break lines consistent in issue forms

* Markdown for Acceptance Criteria

Transform to Markdown the Acceptance Criteria

* Fix Acceptance Criteria

* Change to text area

---------

Co-authored-by: Jean-Robin <[email protected]>
  • Loading branch information
FlorianJacta and jrobinAV authored Jun 12, 2024
1 parent 23d24bf commit 0205668
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 13 deletions.
9 changes: 5 additions & 4 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,12 @@ body:
validations:
required: false

- type: markdown
- type: textarea
id: acceptance_criteria
attributes:
value: |
### Acceptance Criteria
label: "Acceptance Criteria"
description: Do not edit the text area below.
value: |
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
- [ ] Create related issue in taipy-doc for documentation and Release Notes.
Expand Down
11 changes: 6 additions & 5 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,16 @@ body:
validations:
required: false

- type: markdown
- type: textarea
id: acceptance_criteria
attributes:
value: |
### Acceptance Criteria
label: "Acceptance Criteria"
description: Do not edit the text area below.
value: |
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
- [ ] Create related issue in taipy-doc for documentation and Release Notes.
- [ ] Check if a new demo could be provided based on this, or if legacy demos could be benefit from it.
- [ ] Ensure any change is well documented.
- [ ] Ensure any change is well documented.
- type: checkboxes
id: terms_checklist_feature
Expand Down
9 changes: 5 additions & 4 deletions .github/ISSUE_TEMPLATE/refactor-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ body:
description: "Describe what improvements can be made(performance, API...) in the codebase without introducing breaking changes."
validations:
required: true

- type: markdown

- type: textarea
id: acceptance_criteria
attributes:
label: "Acceptance Criteria"
description: Do not edit the text area below.
value: |
### Acceptance Criteria
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
- [ ] Propagate any change on the demos and run all of them to ensure there is no breaking change.
- [ ] Ensure any change is well documented.
Expand Down

0 comments on commit 0205668

Please sign in to comment.