Skip to content

Commit

Permalink
chart: do not show warning on no data bound when figure is declared (#…
Browse files Browse the repository at this point in the history
…1144)

* chart: do not show warning on no data bound when figure is declared (#1107)

* do not show warning on no data bound when figure is declared
resolves #1106

* check data for non chart control

---------

Co-authored-by: Fred Lefévère-Laoide <[email protected]>
(cherry picked from commit 09ace52)

* version 3.1.2

* Long's request

---------

Co-authored-by: Fred Lefévère-Laoide <[email protected]>
  • Loading branch information
FredLL-Avaiga and Fred Lefévère-Laoide authored Apr 9, 2024
1 parent c18ab8b commit b118b5c
Show file tree
Hide file tree
Showing 7 changed files with 819 additions and 721 deletions.
2 changes: 1 addition & 1 deletion frontend/taipy-gui/dom/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "taipy-gui-dom",
"version": "3.1.0",
"version": "3.1.2",
"private": true,
"dependencies": {
"react": "^18.2.0",
Expand Down
1,526 changes: 812 additions & 714 deletions frontend/taipy-gui/package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion frontend/taipy-gui/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "taipy-gui",
"version": "3.1.0",
"version": "3.1.2",
"private": true,
"dependencies": {
"@emotion/react": "^11.10.0",
Expand Down
2 changes: 1 addition & 1 deletion frontend/taipy-gui/packaging/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "taipy-gui",
"version": "3.1.0",
"version": "3.1.2",
"private": true,
"main": "./taipy-gui.js",
"types": "./taipy-gui.d.ts"
Expand Down
2 changes: 1 addition & 1 deletion frontend/taipy/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "taipy-gui-core",
"version": "3.1.0",
"version": "3.1.2",
"private": true,
"devDependencies": {
"@types/react": "^18.0.15",
Expand Down
4 changes: 2 additions & 2 deletions taipy/gui/_renderers/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -775,8 +775,8 @@ def set_value_and_default(
else:
self.__set_default_value(var_name, var_type=var_type)
else:
if var_type == PropertyType.data:
_warn(f"{self.__control_type}.data property should be bound.")
if var_type == PropertyType.data and (self.__control_type != "chart" or "figure" not in self.__attributes):
_warn(f"{self.__control_type}.{var_name} property should be bound.")
value = self.__attributes.get(var_name)
if value is not None:
if native_type:
Expand Down
2 changes: 1 addition & 1 deletion taipy/gui/version.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"major": 3, "minor": 1, "patch": 1}
{"major": 3, "minor": 1, "patch": 2}

0 comments on commit b118b5c

Please sign in to comment.