Skip to content

Commit

Permalink
Fix issue 2319
Browse files Browse the repository at this point in the history
  • Loading branch information
jrobinAV committed Dec 11, 2024
1 parent 44c3663 commit c4cde87
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions taipy/core/_orchestrator/_dispatcher/_job_dispatcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,7 @@ def _update_job_status(job: Job, exceptions):
_TaipyLogger._get_logger().error(st)
_JobManagerFactory._build_manager()._set(job)
else:
for output in job.task.output.values():
output.track_edit(job_id=job.id)
output.unlock_edit()
job.completed()
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def _write_data(self, outputs: List[DataNode], results, job_id: JobId):
for res, dn in zip(_results, outputs):
try:
data_node = data_manager._get(dn.id)
data_node.write(res, job_id=job_id)
data_node._write(res)
except Exception as e:
logger.error("Error during write", exc_info=1)
exceptions.append(DataNodeWritingError(f"Error writing in datanode id {dn.id}: {e}"))
Expand Down
6 changes: 3 additions & 3 deletions tests/core/job/test_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@ def job(task, job_id):

@pytest.fixture
def replace_in_memory_write_fct():
default_write = InMemoryDataNode.write
InMemoryDataNode.write = _error
default_write = InMemoryDataNode._write
InMemoryDataNode._write = _error
yield
InMemoryDataNode.write = default_write
InMemoryDataNode._write = default_write


def _foo():
Expand Down

0 comments on commit c4cde87

Please sign in to comment.