Skip to content

Commit

Permalink
Fix Acceptance Criteria section (#1371)
Browse files Browse the repository at this point in the history
* Change required fields and markdown for screenshots

- Screenshot field is now Markdown
- Required fields changed
- Make break lines consistent in issue forms

* Markdown for Acceptance Criteria

Transform to Markdown the Acceptance Criteria

* Fix Acceptance Criteria

---------

Co-authored-by: Jean-Robin <[email protected]>
  • Loading branch information
FlorianJacta and jrobinAV authored Jun 7, 2024
1 parent b2a6367 commit cfdb397
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 13 deletions.
12 changes: 1 addition & 11 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,20 +116,10 @@ body:
validations:
required: false

- type: checkboxes
id: acceptance_criteria
attributes:
label: Acceptance Criteria
options:
- label: "Ensure new code is unit tested, and check code coverage is at least 90%."
required: false
- label: "Create a related issue in taipy-doc for documentation and Release Notes if relevant."
required: false

- type: markdown
attributes:
value: |
## Acceptance Criteria
### Acceptance Criteria
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
- [ ] Create related issue in taipy-doc for documentation and Release Notes.
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ body:
- type: markdown
attributes:
value: |
## Acceptance Criteria
### Acceptance Criteria
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
- [ ] Create related issue in taipy-doc for documentation and Release Notes.
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/refactor-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ body:
- type: markdown
attributes:
value: |
## Acceptance Criteria
### Acceptance Criteria
- [ ] Ensure new code is unit tested, and check code coverage is at least 90%.
- [ ] Propagate any change on the demos and run all of them to ensure there is no breaking change.
Expand Down

0 comments on commit cfdb397

Please sign in to comment.