Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#551 Expose a metric control #1272
Feature/#551 Expose a metric control #1272
Changes from 21 commits
06892d0
b099da2
b7c0ad5
29ca496
6784551
162b966
1e24f1a
04a0cb6
ede60cf
1e0a2c1
2417590
5d0b519
d789639
ba99a52
d2c72ea
83c0692
f68778a
9122b12
5864234
2dc5d46
1d4fabd
b4491d6
ccc9443
ed21313
47c5061
dc06dca
2a512fc
689566f
1bcf034
af4dd42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, I would change that to
(value === undefined || delta === undefined) ? undefined : (value - delta)
that is more efficient and more readable (value and delta ARE numbers - except when they're not).