Feature/#405 exposing notification mechanism to user #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
1 task
jrobinAV
reviewed
May 29, 2024
| consumer.start() | ||
| # ... | ||
| consumer.stop() | ||
|
|
||
| Notifier.unregister(registration_id) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
After the example I would add a short paragraph to explain the code, and particularly
what are the events we are registering. We can also briefly explain the principle of the topic registration and redirect readers to the register function refman page to make it easier to understand how to build the topic.
jrobinAV
added
Core
toan-quach
force-pushed
the
feature/#405-exposed-notification-mechanism-to-users
branch
from
06df074 to
4de7ae3
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 81.48% | 2680/3289 |
| 🟡 | Branches | 62.72% | 1686/2688 |
| 🟡 | Functions | 74.6% | 467/626 |
| 🟢 | Lines | 82.04% | 2498/3045 |
Test suite run success
379 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 06df074
jrobinAV
approved these changes
May 31, 2024
toan-quach
deleted the
feature/#405-exposed-notification-mechanism-to-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#405