feat: update retry methods and queries on sql repository #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoandre-avaiga
force-pushed
the
fix/sqlrepo-integration-test
branch
2 times, most recently
from
a80efd9 to
fcb17da
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
jrobinAV
reviewed
Jun 4, 2024
| query = self.table.select().filter_by(id=entity_id).order_by(text("updated_at DESC")) | ||
|
|
||
| for _ in range(self.MAX_MODEL_NOT_FOUND_RETRY): | ||
| if entry := self.db.execute(str(query.compile(dialect=sqlite.dialect())), [entity_id]).fetchall(): |
There was a problem hiding this comment.
The behavior we want is to have at most one element returned by this query.
We should at least log a warning if it is not the case.
To investigate why, maybe we can exit as well.
joaoandre-avaiga
force-pushed
the
fix/sqlrepo-integration-test
branch
from
fcb17da to
26f7a7f
Compare
jrobinAV
reviewed
Jun 28, 2024
| IndexError, | ||
| StopIteration, | ||
| ) | ||
| MAX_MODEL_NOT_FOUND_RETRY = 30 |
There was a problem hiding this comment.
Isn't it too much? Or is it for debugging and investigation purpose?
jrobinAV
approved these changes
Jun 28, 2024
|
@jrobinAV I think Im not gonna merge this PR while we discuss about removing sql. |
|
All right. Sounds fair. |
|
Since we decided to remove the sql option for repository type, should we close the PR and delete the branch ? |
|
Closing this since we decided to remove SQL Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.