Cache dependencies on github actions (#1296) #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhlongviolin1
requested review from
florian-vuillemot,
joaoandre-avaiga,
jrobinAV,
FabienLelaquais and
FredLL-Avaiga
dinhlongviolin1
changed the title
dinhlongviolin1
added
🖧 Devops
FredLL-Avaiga
previously approved these changes
May 30, 2024
FabienLelaquais
previously approved these changes
May 30, 2024
dinhlongviolin1
dismissed stale reviews from FabienLelaquais and FredLL-Avaiga
via
9ecf9b9
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
jrobinAV
reviewed
May 30, 2024
The overall tests uses the install/action.yml file for installation of the dependencies. The cache is already implemented in that file. |
We can also remove the python setup within overall-tests.yml file since it will be setup in the install/action.yml file. @florian-vuillemot can you confirm this |
jrobinAV
previously approved these changes
May 30, 2024
florian-vuillemot
previously approved these changes
May 30, 2024
|
Caching the frontend build is also added! |
dinhlongviolin1
requested review from
florian-vuillemot,
FabienLelaquais,
jrobinAV and
FredLL-Avaiga
FredLL-Avaiga
previously approved these changes
May 31, 2024
jrobinAV
approved these changes
May 31, 2024
jrobinAV
previously approved these changes
Jun 11, 2024
|
LGTM! Great job @dinhlongviolin1 |
joaoandre-avaiga
previously approved these changes
Jun 17, 2024
|
@dinhlongviolin1 Let's merge it if that's fine for everyone so we can finally benefit from it. |
dinhlongviolin1
dismissed stale reviews from FredLL-Avaiga, joaoandre-avaiga, and jrobinAV
via
97cad62
dinhlongviolin1
requested review from
florian-vuillemot,
jrobinAV,
joaoandre-avaiga and
FredLL-Avaiga
florian-vuillemot
approved these changes
Jun 18, 2024
FredLL-Avaiga
approved these changes
Jun 18, 2024
jrobinAV
approved these changes
Jun 18, 2024
florian-vuillemot
approved these changes
Jun 20, 2024
joaoandre-avaiga
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1296
Caching for both npm and pipenv (for tests only). Deployment/build will still do everything from scratch.
Caching was also added for frontend build.
For npm, the dependency was declared and those will be used to hash as the cache name.
For pipenv, the recommended file is
Pipfile.lock. But since we don't usePipfile.lock(mainly due to multiple os support),Pipfilewill be used. We might have to manually delete the cache from here if any dev packages get a major/breaking update. Pipenv caching will work both for the min Pipfile and max Pipfile as those will be produce 2 different caches due to the different file hashes.The cache will be removed automatically after 7 days if not used in any action. There is no limit on the number of cache, but there is a hard limit of 10 GB of cache per repo.