-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support filter on selector dropdown #1338
Conversation
update date-fns to 3.x resolves #428
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 81.57% (+0.05% 🔼) |
2705/3316 |
🟡 | Branches | 62.89% (-0.54% 🔻) |
1717/2730 |
🟡 | Functions | 74.84% (+0.01% 🔼) |
479/640 |
🟢 | Lines | 82.13% (+0.05% 🔼) |
2518/3066 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
🟡 | ... / index.ts |
75% | 26.67% | 50% | 74.47% |
🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / Selector.tsx |
92.05% (+0.12% 🔼) |
69.94% (+1.34% 🔼) |
87.5% (-0.96% 🔻) |
92.81% (+0.43% 🔼) |
Test suite run success
386 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from f79b53d
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Really straight forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
One thing that needs to be done is reorder the properties in viselements.json.
Order should be
label, mode, dropdown, multiple, filter, width and height
Co-authored-by: Fabien Lelaquais <[email protected]>
0caf617
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
update date-fns to 3.x
resolves #428