Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support filter on selector dropdown #1338

Merged
merged 4 commits into from
May 31, 2024

Conversation

FredLL-Avaiga
Copy link
Member

update date-fns to 3.x
resolves #428

from taipy.gui import Gui, State

lov = ['node_modules/uuid/dist/esm-browser','src/context','webpack 5.91.0 compiled successfully in 2742 ms']
selected = 'src/context'

def on_change(state: State, var: str, val):
  print(f"on_change(state, var: {var}, val: {val})")

Gui("""<|{selected}|selector|dropdown|filter|lov={lov}|label=dropdown+filter|>
    <|{selected}|selector|dropdown|mode=check|lov={lov}|label=dropdown+check|>
    <|{selected}|selector|dropdown||filter|lov={lov}|label=dropdown+filter|>
    <|{selected}|selector|dropdown|multiple|filter|lov={lov}|label=dropdown+multiple+filter|>
    <|{selected}|selector|dropdown|multiple|don't filter|lov={lov}|label=dropdown+multiple|>
    """).run()

update date-fns to 3.x
resolves #428
@FredLL-Avaiga FredLL-Avaiga added 🟥 Priority: Critical Must be addressed as soon as possible 📈 Improvement Improvement of a feature. 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels May 30, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this May 30, 2024
Copy link
Contributor

github-actions bot commented May 30, 2024

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.89377289377289%

St.
Category Percentage Covered / Total
🟢 Statements
81.57% (+0.05% 🔼)
2705/3316
🟡 Branches
62.89% (-0.54% 🔻)
1717/2730
🟡 Functions
74.84% (+0.01% 🔼)
479/640
🟢 Lines
82.13% (+0.05% 🔼)
2518/3066
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75% 26.67% 50% 74.47%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Selector.tsx
92.05% (+0.12% 🔼)
69.94% (+1.34% 🔼)
87.5% (-0.96% 🔻)
92.81% (+0.43% 🔼)

Test suite run success

386 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from f79b53d

Copy link
Contributor

github-actions bot commented May 30, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18438 16129 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/builder.py 83% 🟢
TOTAL 83% 🟢

updated for commit: f79b53d by action🐍

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really straight forward

namnguyen20999
namnguyen20999 previously approved these changes May 31, 2024
Copy link
Member

@namnguyen20999 namnguyen20999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

One thing that needs to be done is reorder the properties in viselements.json.
Order should be
label, mode, dropdown, multiple, filter, width and height

taipy/gui/_renderers/builder.py Show resolved Hide resolved
Co-authored-by: Fabien Lelaquais <[email protected]>
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga merged commit cff3262 into develop May 31, 2024
155 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#428-selector-dropdown-filter branch May 31, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature. 🟥 Priority: Critical Must be addressed as soon as possible 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to add a filter to a selector even if dropdown is True
4 participants