Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding theme for metric #1364

Merged
merged 6 commits into from
Jun 8, 2024
Merged

Adding theme for metric #1364

merged 6 commits into from
Jun 8, 2024

Conversation

namnguyen20999
Copy link
Member

Adding theme for metric

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Coverage report for frontend/taipy-gui

Branches coverage not met for global: expected >=80%, but got 62.06156048675734%

St.
Category Percentage Covered / Total
🟢 Statements
80.85% (+0.11% 🔼)
2749/3400
🟡 Branches
62.06% (-0.79% 🔻)
1734/2794
🟡 Functions
74.54% (-0.01% 🔻)
486/652
🟢 Lines
81.46% (+0.11% 🔼)
2558/3140
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / Dialog.tsx
80.43% 60.87% 100% 80.43%
🟡
... / TaipyRendered.tsx
64.58% 14.29% 50% 64.58%
🟡
... / index.ts
75% 26.67% 50% 74.47%
🟢
... / darkThemeTemplate.ts
100% 100% 100% 100%
🟢
... / Expandable.tsx
100% 85% 100% 100%
🟢
... / PageContent.tsx
75% 100% 0% 100%
🟢
... / Pane.tsx
95.12% 73.81% 100% 94.87%
🟢
... / Part.tsx
88% 64.29% 75% 91.3%
🟡
... / Unregistered.tsx
62.5% 0% 0% 60%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / Metric.tsx
95.24% (-4.76% 🔻)
56.41% (-20.86% 🔻)
100%
95% (-5% 🔻)

Test suite run success

386 tests passing in 40 suites.

Report generated by 🧪jest coverage report action from 273c6fd

Copy link
Contributor

github-actions bot commented Jun 6, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18550 16188 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/factory.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 273c6fd by action🐍

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Jun 6, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

FabienLelaquais
FabienLelaquais previously approved these changes Jun 6, 2024
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
I trust you didn't mess anything in darkThemeTemplate.ts!

taipy/gui/viselements.json Outdated Show resolved Hide resolved
taipy/gui/viselements.json Outdated Show resolved Hide resolved
taipy/gui/_renderers/factory.py Show resolved Hide resolved
@namnguyen20999 namnguyen20999 merged commit 78e1736 into develop Jun 8, 2024
155 checks passed
@namnguyen20999 namnguyen20999 deleted the metric-theme branch July 1, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 📈 Improvement Improvement of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants