adding color-map property to Metric #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namnguyen20999
requested review from
dinhlongviolin1,
FabienLelaquais and
FredLL-Avaiga
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.75% (-0.12% 🔻) |
2777/3439 |
| 🟡 | Branches | 61.99% (-0.82% 🔻) |
1755/2831 |
| 🟡 | Functions | 74.12% (-0.51% 🔻) |
487/657 |
| 🟢 | Lines | 81.37% (-0.12% 🔻) |
2586/3178 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
| 🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
| 🟡 | ... / index.ts |
75.51% | 26.67% | 50% | 75% |
| 🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
| 🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
| 🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
| 🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
| 🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Metric.tsx |
83.05% (-10.57% 🔻) |
49.06% (-8.09% 🔻) |
72.73% (-27.27% 🔻) |
83.93% (-9.4% 🔻) |
Test suite run success
400 tests passing in 41 suites.
Report generated by 🧪jest coverage report action from a100f8d
FredLL-Avaiga
requested changes
Jun 13, 2024
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
…roperty-to-metric-component
FredLL-Avaiga
previously approved these changes
Jun 14, 2024
…ric-component' of github.com:Avaiga/taipy into 1396-discussion-adding-color_range_step-property-to-metric-component
…roperty-to-metric-component
…roperty-to-metric-component
…roperty-to-metric-component
…ric-component' of github.com:Avaiga/taipy into 1396-discussion-adding-color_range_step-property-to-metric-component
FredLL-Avaiga
approved these changes
Jun 20, 2024
| # ----------------------------------------------------------------------------------------- | ||
| from taipy.gui import Gui | ||
|
|
||
| # color_map = { |
There was a problem hiding this comment.
I suppose that @FabienLelaquais meant to have to comments inline (in the variable color_map dict)
There was a problem hiding this comment.
I think putting it seperated would make it more readable
namnguyen20999
deleted the
1396-discussion-adding-color_range_step-property-to-metric-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1396