Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#671 - Add gitignore and git init to templates #1438

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

trgiangdo
Copy link
Member

Resolves #671

@trgiangdo trgiangdo added the 📈 Improvement Improvement of a feature. label Jun 21, 2024
@trgiangdo trgiangdo self-assigned this Jun 21, 2024
jrobinAV
jrobinAV previously approved these changes Jun 21, 2024
Copy link
Member

@jrobinAV jrobinAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @trgiangdo for taking over this PR.

FlorianJacta
FlorianJacta previously approved these changes Jun 21, 2024
Copy link
Member

@FlorianJacta FlorianJacta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

toan-quach
toan-quach previously approved these changes Jun 21, 2024
Copy link
Member

@toan-quach toan-quach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT :D

@trgiangdo trgiangdo dismissed stale reviews from toan-quach, FlorianJacta, and jrobinAV via bc2afed June 21, 2024 08:22
@trgiangdo trgiangdo requested review from jrobinAV and toan-quach June 21, 2024 08:24
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
18440 16070 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: bc2afed by action🐍

@trgiangdo trgiangdo merged commit 90e5c81 into develop Jun 21, 2024
151 checks passed
@trgiangdo trgiangdo deleted the feature/#671-add-git-init-to-templates branch June 21, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Improvement Improvement of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .gitignore and init git repo for taipy cli
4 participants