Number visual element #1442
Closed
Number visual element #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
namnguyen20999
requested review from
FredLL-Avaiga,
FabienLelaquais,
dinhlongviolin1 and
jrobinAV
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.61% (-0.12% 🔻) |
2794/3466 |
| 🟡 | Branches | 61.2% (-1.43% 🔻) |
1757/2871 |
| 🟡 | Functions | 73.53% (-0.78% 🔻) |
489/665 |
| 🟢 | Lines | 81.27% (-0.09% 🔻) |
2603/3203 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
| 🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
| 🟡 | ... / index.ts |
75.51% | 26.67% | 50% | 75% |
| 🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
| 🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
| 🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
| 🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
| 🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Input.tsx |
79.01% (-8.02% 🔻) |
43.59% (-40.62% 🔻) |
45% (-13.33% 🔻) |
82.89% (-7.3% 🔻) |
Test suite run success
400 tests passing in 41 suites.
Report generated by 🧪jest coverage report action from b85030e
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
FabienLelaquais
previously approved these changes
Jun 25, 2024
…uld-have-property-type-step
…uld-have-property-type-step
…rty-type-step' of github.com:Avaiga/taipy into 1429-the-number-visual-element-number-should-have-property-type-step
FredLL-Avaiga
requested changes
Jun 28, 2024
|
|
||
| const AUTHORIZED_KEYS = ["Enter", "Escape", "F1", "F2", "F3", "F4", "F5", "F6", "F7", "F8", "F9", "F10", "F11", "F12"]; | ||
|
|
||
| const StyledTextField = styled(TextField)({ | ||
| '& input[type=number]::-webkit-outer-spin-button, & input[type=number]::-webkit-inner-spin-button': { |
There was a problem hiding this comment.
Not sure we want to use WebKit or mozilla specific css...
There was a problem hiding this comment.
We do if this is mandatory for specific browsers.
I don't like it either though.
FabienLelaquais
previously approved these changes
Jun 28, 2024
| value = 50 | ||
|
|
||
| page = """ | ||
| <|{value}|number|step=2|> |
FabienLelaquais
added
📈 Improvement
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.62% (+0.18% 🔼) |
2796/3468 |
| 🟡 | Branches | 61.22% (-1.18% 🔻) |
1760/2875 |
| 🟡 | Functions | 73.53% (-0.43% 🔻) |
489/665 |
| 🟢 | Lines | 81.28% (+0.24% 🔼) |
2605/3205 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Dialog.tsx |
80.43% | 60.87% | 100% | 80.43% |
| 🟡 | ... / TaipyRendered.tsx |
64.58% | 14.29% | 50% | 64.58% |
| 🟡 | ... / index.ts |
75.51% | 26.67% | 50% | 75% |
| 🟢 | ... / Expandable.tsx |
100% | 85% | 100% | 100% |
| 🟢 | ... / PageContent.tsx |
75% | 100% | 0% | 100% |
| 🟢 | ... / Pane.tsx |
95.12% | 73.81% | 100% | 94.87% |
| 🟢 | ... / Part.tsx |
88% | 64.29% | 75% | 91.3% |
| 🟡 | ... / Unregistered.tsx |
62.5% | 0% | 0% | 60% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / Input.tsx |
79.52% (-7.52% 🔻) |
45.12% (-39.09% 🔻) |
45% (-13.33% 🔻) |
83.33% (-6.86% 🔻) |
Test suite run success
400 tests passing in 41 suites.
Report generated by 🧪jest coverage report action from 1d6239f
namnguyen20999
deleted the
1429-the-number-visual-element-number-should-have-property-type-step
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1429